content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm - Issue 647613002: Fix RenderWidgetHostViewGuest leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add is_guest_view_hack_ check in rwhvmac-delegate call (needs review) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/renderer_host/render_widget_host_view_mac_unittest.mm » ('j') | content/browser/web_contents/web_contents_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

index b444282ac14f35f8b12ed0da3a8c8555d470d073..ab9c9458bcdd1424e673c1175688bef378e334dd 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

@@ -133,7 +133,7 @@ TEST_F(RenderWidgetHostViewMacEditCommandHelperTest,

// Owned by its |cocoa_view()|, i.e. |rwhv_cocoa|.

RenderWidgetHostViewMac* rwhv_mac = new RenderWidgetHostViewMac(

- render_widget);

+ render_widget, false);

base::scoped_nsobject<RenderWidgetHostViewCocoa> rwhv_cocoa(

[rwhv_mac->cocoa_view() retain]);