Fix RenderWidgetHostViewGuest leak.

content/browser/web_contents/web_contents_view_guest.cc

Index: content/browser/web_contents/web_contents_view_guest.cc
diff --git a/content/browser/web_contents/web_contents_view_guest.cc b/content/browser/web_contents/web_contents_view_guest.cc
index 675cfae40f0e5f3563e0813db8b1e8a000cad62f..4b2059a233facd288719b4140432130916d09295 100644
--- a/content/browser/web_contents/web_contents_view_guest.cc
+++ b/content/browser/web_contents/web_contents_view_guest.cc
@@ -140,7 +140,7 @@ void WebContentsViewGuest::CreateView(const gfx::Size& initial_size,
 }
 
 RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForWidget(
-    RenderWidgetHost* render_widget_host) {
+    RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
   if (render_widget_host->GetView()) {
     // During testing, the view will already be set up in most cases to the
     // test view, so we don't want to clobber it with a real one. To verify that
@@ -153,16 +153,16 @@ RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForWidget(
   }
 
   RenderWidgetHostViewBase* platform_widget =
-      platform_view_->CreateViewForWidget(render_widget_host);
+      platform_view_->CreateViewForWidget(render_widget_host, true);
 
   return new RenderWidgetHostViewGuest(render_widget_host,
                                        guest_,
-                                       platform_widget);
+                                       platform_widget->GetWeakPtr());
 }
 
 RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForPopupWidget(
-    RenderWidgetHost* render_widget_host) {
-  return platform_view_->CreateViewForPopupWidget(render_widget_host);
+    RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
+  return platform_view_->CreateViewForPopupWidget(render_widget_host, true);

[piman, 2014/10/14 23:48:06]

I don't think we should pass true. This is called when we want to create a
popup, with a new top-level RWH, but that view doesn't become a
RenderWidgetHostViewGuest's platform_view, right?

I don't think we need to pass the is_guest_view_hack in all the
CreateViewForPopupWidget's.

[lazyboy, 2014/10/15 04:50:11]

Oh that's right, these views don't have a wrapped RWHVGuest.
Reverted CreateViewForPopupWidget changes.

 }
 
 void WebContentsViewGuest::SetPageTitle(const base::string16& title) {