Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: content/browser/web_contents/web_contents_view_guest.h

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add is_guest_view_hack_ to RWHV Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_guest.h
diff --git a/content/browser/web_contents/web_contents_view_guest.h b/content/browser/web_contents/web_contents_view_guest.h
index ae72f5b442a71fb9bc8cd989b7061a5f216426cb..26d4fef8f2a5b1516492777d78358d18f6d930c0 100644
--- a/content/browser/web_contents/web_contents_view_guest.h
+++ b/content/browser/web_contents/web_contents_view_guest.h
@@ -59,9 +59,9 @@ class WebContentsViewGuest : public WebContentsView,
virtual void CreateView(const gfx::Size& initial_size,
gfx::NativeView context) override;
virtual RenderWidgetHostViewBase* CreateViewForWidget(
- RenderWidgetHost* render_widget_host) override;
+ RenderWidgetHost* render_widget_host, bool is_guest_view_hack) override;
virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(
- RenderWidgetHost* render_widget_host) override;
+ RenderWidgetHost* render_widget_host, bool is_guest_view_hack) override;
virtual void SetPageTitle(const base::string16& title) override;
virtual void RenderViewCreated(RenderViewHost* host) override;
virtual void RenderViewSwappedIn(RenderViewHost* host) override;

Powered by Google App Engine
This is Rietveld 408576698