Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 63933003: Moved ExtensionInfoMap and ExtensionsQuotaService to extensions/ (Closed)

Created:
7 years, 1 month ago by benwells
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, chrome-apps-syd-reviews_chromium.org, James Cook, Daniel Erat
Visibility:
Public.

Description

Moved ExtensionInfoMap and ExtensionsQuotaService to extensions/ In the move these classes became extensions::InfoMap and extensions::QuotaService. TBR=sky BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234131

Patch Set 1 #

Patch Set 2 : Compile #

Patch Set 3 : Cleanup #

Total comments: 1

Patch Set 4 : Rebase #

Patch Set 5 : Comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -1702 lines) Patch
M chrome/browser/apps/app_url_redirector.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_throttle.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 9 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_cache_delegate.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_rules_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/test/test_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 11 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 19 chunks +26 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function.h View 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 5 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/extensions/extension_info_map.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/extensions/extension_info_map.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/extensions/extension_info_map_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
M chrome/browser/extensions/extension_protocols.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 2 3 7 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/extensions/extension_service.h View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/extensions/extension_service.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 2 6 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 6 chunks +15 lines, -15 lines 0 comments Download
D chrome/browser/extensions/extensions_quota_service.h View 1 chunk +0 lines, -238 lines 0 comments Download
D chrome/browser/extensions/extensions_quota_service.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/extensions/extensions_quota_service_unittest.cc View 1 chunk +0 lines, -415 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/user_script_master.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/DEPS View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
A + extensions/browser/info_map.h View 1 2 3 4 6 chunks +18 lines, -16 lines 0 comments Download
A + extensions/browser/info_map.cc View 7 chunks +40 lines, -44 lines 0 comments Download
A + extensions/browser/info_map_unittest.cc View 8 chunks +36 lines, -42 lines 0 comments Download
A + extensions/browser/quota_service.h View 10 chunks +20 lines, -16 lines 0 comments Download
A + extensions/browser/quota_service.cc View 10 chunks +31 lines, -30 lines 0 comments Download
A + extensions/browser/quota_service_unittest.cc View 14 chunks +32 lines, -30 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benwells
7 years, 1 month ago (2013-11-07 22:49:47 UTC) #1
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/63933003/diff/100001/extensions/browser/info_map.h File extensions/browser/info_map.h (right): https://chromiumcodereview.appspot.com/63933003/diff/100001/extensions/browser/info_map.h#newcode105 extensions/browser/info_map.h:105: // The QutoaService is not thread safe. We ...
7 years, 1 month ago (2013-11-08 21:48:51 UTC) #2
benwells
+tbr sky for refactoring fallout
7 years, 1 month ago (2013-11-09 09:03:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/63933003/180001
7 years, 1 month ago (2013-11-09 09:03:51 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 17:34:30 UTC) #5
Message was sent while issue was closed. 
Change committed as 234131

Powered by Google App Engine
This is Rietveld 408576698