Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: estade@ review Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
index 4a7d46b493466afef5fce084a8d95c17ac1dd4e1..35864f33b6b6efd3248938b24f27db909fd1b471 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
@@ -16,6 +16,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
#include "testing/platform_test.h"
+#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/combobox_model.h"
#include "ui/base/models/simple_menu_model.h"
#import "ui/base/test/ui_cocoa_test_helper.h"
@@ -121,7 +122,7 @@ TEST_F(AutofillSectionContainerTest, OutputMatchesDefinition) {
const DetailInput kTestInputs[] = {
{ DetailInput::LONG,
EMAIL_ADDRESS,
- IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },
groby-ooo-7-16 2014/01/04 01:15:33 Since the string constants are never used in the t
Dan Beam 2014/01/04 01:39:23 Done.
{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH },
};
autofill::MonthComboboxModel comboModel;
@@ -186,7 +187,7 @@ TEST_F(AutofillSectionContainerTest, FieldsAreInitiallyValid) {
const DetailInput kTestInputs[] = {
{ DetailInput::LONG,
EMAIL_ADDRESS,
- IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },
{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH },
};
@@ -214,7 +215,9 @@ TEST_F(AutofillSectionContainerTest, ControllerInformsValidity) {
using namespace testing;
const DetailInput kTestInputs[] = {
- { DetailInput::LONG, EMAIL_ADDRESS, IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },
+ { DetailInput::LONG,
+ EMAIL_ADDRESS,
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },
{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH }
};

Powered by Google App Engine
This is Rietveld 408576698