chrome/browser/ui/cocoa/autofill/autofill_section_container.mm - Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: estade@ review Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/mock_autofill_dialog_view_delegate.cc ('k') | chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm » ('j') | chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

index 8557450ef6c25d0426130f226a837cc2f07d28c8..f840d9b6d9fdf724bf298f658b1fc2d3196a0301 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

@@ -621,7 +621,7 @@ bool ShouldOverwriteComboboxes(autofill::DialogSection section,

base::scoped_nsobject<AutofillTextField> field(

[[AutofillTextField alloc] init]);

[[field cell] setPlaceholderString:

- l10n_util::GetNSStringWithFixup(input.placeholder_text_rid)];

+ base::SysUTF16ToNSString(input.placeholder_text)];

groby-ooo-7-16 2014/01/04 01:15:33 Unless you are 100% certain there will never be el

Dan Beam 2014/01/04 01:39:23 meh, guess it doesn't hurt. Done.

NSString* tooltipText =

base::SysUTF16ToNSString(delegate_->TooltipForField(input.type));

if ([tooltipText length] > 0) {

@@ -652,8 +652,10 @@ bool ShouldOverwriteComboboxes(autofill::DialogSection section,

}

layout->AddView(control);

- if (input.length == autofill::DetailInput::LONG)

+ if (input.length == autofill::DetailInput::LONG ||

+ input.length == autofill::DetailInput::SHORT_EOL) {

++column_set_id;

+ }

}

[self updateFieldIcons];