Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 62563003: Android: adds "test_runner.py perf -vvv --single-step" in telemetry.py (Closed)

Created:
7 years, 1 month ago by bulach
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Android: adds "test_runner.py perf -vvv --single-step" in telemetry.py Buildbot side of https://codereview.chromium.org/66373004/. This will allow chromium.perf to use roughly the same mechanism as downstream bots. BUG= R=frankf@chromium.org, stip@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234526

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M scripts/slave/telemetry.py View 1 3 chunks +7 lines, -10 lines 0 comments Download
M scripts/slave/unittests/telemetry_test.py View 1 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
7 years, 1 month ago (2013-11-08 15:09:04 UTC) #1
tonyg
lgtm
7 years, 1 month ago (2013-11-08 15:27:26 UTC) #2
ghost stip (do not use)
lgtm, but wait for https://chromiumcodereview.appspot.com/66373004/ to land successfully
7 years, 1 month ago (2013-11-11 21:54:49 UTC) #3
frankf
lgtm w/ a question https://chromiumcodereview.appspot.com/62563003/diff/1/scripts/slave/telemetry.py File scripts/slave/telemetry.py (right): https://chromiumcodereview.appspot.com/62563003/diff/1/scripts/slave/telemetry.py#newcode93 scripts/slave/telemetry.py:93: wrapper_args = ['src/build/android/test_runner.py', 'perf', '-vvv', ...
7 years, 1 month ago (2013-11-11 22:01:52 UTC) #4
ghost stip (do not use)
https://chromiumcodereview.appspot.com/62563003/diff/1/scripts/slave/telemetry.py File scripts/slave/telemetry.py (right): https://chromiumcodereview.appspot.com/62563003/diff/1/scripts/slave/telemetry.py#newcode84 scripts/slave/telemetry.py:84: commands = [['adb', 'root'], ['adb', 'wait-for-device']] do we need ...
7 years, 1 month ago (2013-11-11 22:29:10 UTC) #5
bulach
thanks both! all comments addressed.. tony, would you mind pinging when you're around? I'd truly ...
7 years, 1 month ago (2013-11-12 14:00:34 UTC) #6
bulach
7 years, 1 month ago (2013-11-12 15:44:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r234526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698