Android: adds "test_runner.py perf -vvv --single-step" in telemetry.py

scripts/slave/telemetry.py

 #! /usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set up and invoke telemetry tests."""
 
 import json
 import optparse
 import os
 import sys
 
 from common import chromium_utils
 
 
 SCRIPT_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
 
 
 def _GetPythonTestCommand(py_script, target, build_dir, arg_list=None,
-                         wrapper_args=None, fp=None):
+                          wrapper_args=None, fp=None):
   """Synthesizes a command line to run runtest.py."""
   cmd = [sys.executable,
          os.path.join(SCRIPT_DIR, 'slave', 'runtest.py'),
          '--run-python-script',
          '--target', target,
          '--build-dir', build_dir,
          '--no-xvfb'] #  telemetry.py should be run by a 'master' runtest.py
                       #  which starts xvfb on linux.
   if fp:
     cmd.extend(["--factory-properties=%s" % json.dumps(fp)])
@@ skipping 43 matching lines @@
   # List of command line arguments common to all test platforms.
   common_args = ['-v', '--output-format=buildbot']
   if extra_args:
     common_args.extend(extra_args)
 
   # On android, telemetry needs to use the adb command and needs to be in
   # root mode. Run it in bash since envsetup.sh doesn't work in sh.
   if target_os == 'android':
     env['PATH'] = os.pathsep.join(['/b/build_internal/scripts/slave/android',
                                    env['PATH']])
     commands = [['adb', 'root'], ['adb', 'wait-for-device']]

[ghost stip (do not use), 2013/11/11 22:29:11]

do we need to have lines 81-86 here since we're now calling into test_runner.py?

[bulach, 2013/11/12 14:00:34]

oh, good point! done.

   else:
     commands = []
 
   # Run the test against the target chrome build.
   browser = target.lower()
+  wrapper_args = None
   if target_os == 'android':
     browser = options.target_android_browser
+    wrapper_args = ['src/build/android/test_runner.py', 'perf', '-vvv',

[frankf, 2013/11/11 22:01:53]

nit: Do you really want to log at DEBUG level? We use INFO for functional tests.

+                    '--single-step']
   # If an executable is passed, use that instead.
   if browser_exe:
     browser_info = ['--browser=exact',
                     '--browser-executable=%s' % browser_exe]
   else:
     browser_info = ['--browser=%s' % browser]
   test_args = list(common_args)
   test_args.extend(browser_info)
   test_args.extend(test_specification)
-  test_cmd = _GetPythonTestCommand(script, target, build_dir, test_args, fp=fp)
+  test_cmd = _GetPythonTestCommand(script, target, build_dir, test_args,
+                                   wrapper_args=wrapper_args, fp=fp)
   commands.append(test_cmd)
 
   # Run the test against the target chrome build for different user profiles on
   # certain page cyclers.
   if target_os != 'android':
     if test_name in ('page_cycler_moz', 'page_cycler_morejs'):
       test_args = list(common_args)
       test_args.extend(['--profile-type=typical_user',
                         '--output-trace-tag=_extcs1'])
       test_args.extend(browser_info)
@@ skipping 52 matching lines @@
       continue
 
     retval = chromium_utils.RunCommand(command, env=env)
     if retval != 0:
       break
   return retval
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))