Dart plugin SDK update URL fix (dartbug.com/15163).

Dart plugin SDK update URL fix.

NOTE: this looks for a file "com.google.dart.tools.core/update.properties" which as of yet has not been added to the build. In the event that it is not found, we fall back to the dev channel.

R=danrubel@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30479

[danrubel, 2013-11-19 18:51:06]

lgtm

[pquitslund, 2013-11-20 00:13:48]

On 2013/11/19 18:51:06, danrubel wrote:
> lgtm

Improved to add "update.properties" lookup as we discussed.  PTAL!

[kustermann, 2013-11-20 10:23:44]

lgtm

Is there a bug where we track this?
[i.e. adding the update.properties file to our plugin builds]

https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com....
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java
(right):

https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com....
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java:373:
URL url = new
URL("platform:/plugin/com.google.dart.tools.core/update.properties");
I'm not familiar with this, but I trust you that it works :)

https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com....
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java:378:
return properties.getProperty("com.dart.tools.update.core.url");
Maybe you could share the "com.dart.tools.update.core.url" string with the other
files, by making a constant somewhere ?

[danrubel, 2013-11-20 14:29:08]

LGTM

[pquitslund, 2013-11-20 16:48:03]

https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com....
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java
(right):

https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com....
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java:378:
return properties.getProperty("com.dart.tools.update.core.url");
On 2013/11/20 10:23:44, kustermann wrote:
> Maybe you could share the "com.dart.tools.update.core.url" string with the
other
> files, by making a constant somewhere ?
Good call. Done!

[pquitslund, 2013-11-20 19:10:01]

Committed patchset #3 manually as r30479 (presubmit successful).