Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 61663003: Dart plugin SDK update URL fix (dartbug.com/15163). (Closed)

Created:
7 years, 1 month ago by pquitslund
Modified:
7 years, 1 month ago
Reviewers:
ricow1, danrubel, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Dart plugin SDK update URL fix. NOTE: this looks for a file "com.google.dart.tools.core/update.properties" which as of yet has not been added to the build. In the event that it is not found, we fall back to the dev channel. R=danrubel@google.com, kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=30479

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java View 1 2 5 chunks +41 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/UpdateCore.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pquitslund
7 years, 1 month ago (2013-11-19 18:40:07 UTC) #1
danrubel
lgtm
7 years, 1 month ago (2013-11-19 18:51:06 UTC) #2
pquitslund
On 2013/11/19 18:51:06, danrubel wrote: > lgtm Improved to add "update.properties" lookup as we discussed. ...
7 years, 1 month ago (2013-11-20 00:13:48 UTC) #3
kustermann
lgtm Is there a bug where we track this? [i.e. adding the update.properties file to ...
7 years, 1 month ago (2013-11-20 10:23:44 UTC) #4
danrubel
LGTM
7 years, 1 month ago (2013-11-20 14:29:08 UTC) #5
pquitslund
https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java (right): https://codereview.chromium.org/61663003/diff/50001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java#newcode378 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java:378: return properties.getProperty("com.dart.tools.update.core.url"); On 2013/11/20 10:23:44, kustermann wrote: > Maybe ...
7 years, 1 month ago (2013-11-20 16:48:03 UTC) #6
pquitslund
7 years, 1 month ago (2013-11-20 19:10:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r30479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698