chrome/android/java/res/values/dimens.xml - Issue 606153002: [android] Password generation UI for android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify default text color. Use integers instead of enums. Simplify delegate. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 38def67ebc5d2a666b8e1efc5cdb41d4d385aa6b..ff9767c11a4e449ee6f654593bdb628412565056 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -77,4 +77,11 @@

+

+ <dimen name="password_generation_divider_height">1dp</dimen>

+ <dimen name="password_generation_text_size">14sp</dimen>

+ <dimen name="password_generation_horizontal_margin">10dp</dimen>

+ <dimen name="password_generation_icon_vertical_margin">13.5dp</dimen>

aurimas (slooooooooow) 2014/10/16 23:30:01 We shouldn't use half dps as it can look fuzzy on

please use gerrit instead 2014/10/17 05:19:00 Changed 13.5dp -> 13dp.

+ <dimen name="password_generation_text_vertical_margin">12.5dp</dimen>

aurimas (slooooooooow) 2014/10/16 23:30:01 Same here.

please use gerrit instead 2014/10/17 05:19:00 Changed 12.5dp -> 12dp.

</resources>