chrome/android/java/res/values/dimens.xml - Issue 606153002: [android] Password generation UI for android.

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify default text color. Use integers instead of enums. Simplify delegate. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/values/colors.xml ('K') | « chrome/android/java/res/values/colors.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGeneration.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGeneration.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <resources>	7 <resources>

8 <!-- Certificate Viewer Dimensions -->	8 <!-- Certificate Viewer Dimensions -->

9 <dimen name="certificate_viewer_padding_wide">24dp</dimen>	9 <dimen name="certificate_viewer_padding_wide">24dp</dimen>

10 <dimen name="certificate_viewer_padding_thin">16dp</dimen>	10 <dimen name="certificate_viewer_padding_thin">16dp</dimen>

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 <dimen name="app_banner_title_text_size">20sp</dimen>	70 <dimen name="app_banner_title_text_size">20sp</dimen>

71 <dimen name="app_banner_title_margin_top">0dp</dimen>	71 <dimen name="app_banner_title_margin_top">0dp</dimen>

72 <dimen name="app_banner_title_margin_bottom">8dp</dimen>	72 <dimen name="app_banner_title_margin_bottom">8dp</dimen>

73	73

74 <dimen name="app_banner_logo_height">24dp</dimen>	74 <dimen name="app_banner_logo_height">24dp</dimen>

75 <dimen name="app_banner_logo_margin_top">4dp</dimen>	75 <dimen name="app_banner_logo_margin_top">4dp</dimen>

76 <dimen name="app_banner_logo_margin_bottom">0dp</dimen>	76 <dimen name="app_banner_logo_margin_bottom">0dp</dimen>

77 <dimen name="app_banner_logo_margin_end">8dp</dimen>	77 <dimen name="app_banner_logo_margin_end">8dp</dimen>

78	78

79 <dimen name="app_banner_star_height">16dp</dimen>	79 <dimen name="app_banner_star_height">16dp</dimen>

	80

	81 <!-- Password generation popup dimensions -->

	82 <dimen name="password_generation_divider_height">1dp</dimen>

	83 <dimen name="password_generation_text_size">14sp</dimen>

	84 <dimen name="password_generation_horizontal_margin">10dp</dimen>

	85 <dimen name="password_generation_icon_vertical_margin">13.5dp</dimen>
	aurimas (slooooooooow) 2014/10/16 23:30:01 We shouldn't use half dps as it can look fuzzy on We shouldn't use half dps as it can look fuzzy on certain screen densities. please use gerrit instead 2014/10/17 05:19:00 Changed 13.5dp -> 13dp. Show quoted text On 2014/10/16 23:30:01, aurimas wrote: > We shouldn't use half dps as it can look fuzzy on certain screen densities. Changed 13.5dp -> 13dp.
	86 <dimen name="password_generation_text_vertical_margin">12.5dp</dimen>
	aurimas (slooooooooow) 2014/10/16 23:30:01 Same here. Same here. please use gerrit instead 2014/10/17 05:19:00 Changed 12.5dp -> 12dp. Show quoted text On 2014/10/16 23:30:01, aurimas wrote: > Same here. Changed 12.5dp -> 12dp.
80 </resources>	87 </resources>

OLD	NEW