Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2774)

Unified Diff: chrome/browser/resources/options/automatic_settings_reset_banner.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks
Patch Set: describe supressions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/automatic_settings_reset_banner.js
diff --git a/chrome/browser/resources/options/automatic_settings_reset_banner.js b/chrome/browser/resources/options/automatic_settings_reset_banner.js
index b16f6cbe0694c5bedf05740a86af564ba33e771e..e0747c58e15109a6f1399dfb33a5bd888b2741b7 100644
--- a/chrome/browser/resources/options/automatic_settings_reset_banner.js
+++ b/chrome/browser/resources/options/automatic_settings_reset_banner.js
@@ -23,6 +23,12 @@ cr.define('options', function() {
/**
* Initializes the banner's event handlers.
+ * @suppress {checkTypes}
+ * TODO(vitalyp): remove the suppression. Suppression is needed because
+ * method dismiss() is attached to AutomaticSettingsResetBanner at run-time
+ * via "Forward public APIs to protected implementations" pattern (see
+ * below). Currently the compiler pass and cr.js handles only forwarding to
+ * private implementations using cr.makePublic().
*/
initialize: function() {
this.showMetricName = 'AutomaticSettingsReset_WebUIBanner_BannerShown';
« no previous file with comments | « chrome/browser/resources/options/alert_overlay.js ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698