Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: chrome/browser/resources/options/alert_overlay.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks
Patch Set: describe supressions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/automatic_settings_reset_banner.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/alert_overlay.js
diff --git a/chrome/browser/resources/options/alert_overlay.js b/chrome/browser/resources/options/alert_overlay.js
index cd7aaf36a093207d6206c41a33652162cd8f892d..2206517d08003057a039a9f15fb00e092222e16a 100644
--- a/chrome/browser/resources/options/alert_overlay.js
+++ b/chrome/browser/resources/options/alert_overlay.js
@@ -75,7 +75,7 @@ cr.define('options', function() {
* @override
*/
willHidePage: function() {
- canShow_ = false;
+ this.canShow_ = false;
},
/** @override */
@@ -93,10 +93,10 @@ cr.define('options', function() {
* no button is shown.
* @param {string} cancelTitle The title of the cancel button. If undefined or
* empty, no button is shown.
- * @param {function} okCallback A function to be called when the user presses
- * the ok button. The alert window will be closed automatically. Can be
- * undefined.
- * @param {function} cancelCallback A function to be called when the user
+ * @param {function()} okCallback A function to be called when the user
+ * presses the ok button. The alert window will be closed automatically.
+ * Can be undefined.
+ * @param {function()} cancelCallback A function to be called when the user
* presses the cancel button. The alert window will be closed
* automatically. Can be undefined.
*/
« no previous file with comments | « no previous file | chrome/browser/resources/options/automatic_settings_reset_banner.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698