Change log level to show real errors in release mode

We can obtain useful logs in release mode and can debug faster in the future.

BUG=415041
TEST=run VEA unittest and make sure LOG(ERROR) works well.

Committed: https://crrev.com/b1f97630024706465759fb07a5308805b78a0c87
Cr-Commit-Position: refs/heads/master@{#297983}

[henryhsu, 2014-09-23 05:47:55]

henryhsu@chromium.org changed reviewers:
+ posciak@chromium.org, wuchengli@chromium.org

[henryhsu, 2014-09-23 05:47:56]

PTAL

[wuchengli, 2014-09-23 08:08:31]

Add VDA and VEA to the title. Since this is not a simple search-and-replace,
change the title to something like "Log errors in Release build for VDA and
VEA"? Please come up with a descriptive title.

Please look through every LOG. Some DVLOG or DPLOG need to be changed.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/tegra_v4l2_video_device.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:58: LOG(WARNING) << "Failed
to load libtegrav4l2.so ";
As discussed, use LOG(ERROR) because it should not happen and indicates a real
bug. Same for others.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:112: LOG(WARNING) <<
"TegraV4L2Poll returned -1 ";
When this happens, will it keep spamming the logs? We don't want to log this 30
times per second. Pawel. What's your opinion?

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:161: LOG(WARNING) << "Unable
to initialize functions ";
Help remove extra space at the end of the string.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/v4l2_image_processor.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:29: DPLOG(ERROR) << __func__ <<
"(): ioctl() failed: " << #type; \
Do we want to log this?

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:43: DPLOG(ERROR) << __func__ <<
"(): ioctl() failed: " << #type; \
Do we want to log this?

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:113: LOG(WARNING) <<
"Unrecognized format(s)";
I don't think this is a real error. The user of this API should decide it.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:36: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: " << #type; \
Do we want to log this?

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:51: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: " << #type; \
Do we want to log this?

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:231: LOG(WARNING) <<
"Initialize(): unsupported profile=" << profile;
Not a real error. The client can test if a profile is supported. We shouldn't
log it.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:968: DPLOG(ERROR) <<
"SetDevicePollInterrupt(): failed";
PLOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:990: DPLOG(ERROR) <<
"SetDevicePollInterrupt(): failed";
PLOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1046: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1046: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1077: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1447: DPLOG(ERROR) <<
"SetDevicePollInterrupt(): failed";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1548: DVLOG(3) <<
"Couldn't get format information after resolution change";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1554: DVLOG(3) <<
"Couldn't reallocate buffers after resolution change";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1636: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: VIDIOC_G_FMT";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1712: DPLOG(ERROR) <<
"CreateInputBuffers(): mmap() failed";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1839: DPLOG(ERROR) <<
"DestroyOutputBuffers() ioctl() failed: VIDIOC_REQBUFS";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:31: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: " << #type; \
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:503: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:531: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:1050: DPLOG(ERROR) <<
"CreateOutputBuffers(): mmap() failed";
PLOG

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:172: DVLOG(1) <<
"Failed creating an X Pixmap for TFP";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:185: DVLOG(1) <<
"Failed creating a GLX Pixmap for TFP";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:222: DVLOG(1) <<
"Picture id " << picture_buffer_id << " does not exist";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:298: DVLOG(1) <<
"Could not get a usable FBConfig";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:309: DVLOG(1) <<
"Failed initializing VAAPI";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/vaapi_video_encode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_encode_accelerator.cc:226: DVLOGF(1) <<
"Failed initializing VAAPI";
LOG(ERROR)

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_encode_accelerator.cc:231: DVLOGF(1) <<
"Failed to start encoder thread";
LOG(ERROR)

[wuchengli, 2014-09-23 08:16:55]

BTW, Pawel should know better which are real errors and which are not. Some of
my comments could be wrong.

[henryhsu, 2014-09-23 12:08:08]

Sorry, include rebase code.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/tegra_v4l2_video_device.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:58: LOG(WARNING) << "Failed
to load libtegrav4l2.so ";
On 2014/09/23 08:08:29, wuchengli wrote:
> As discussed, use LOG(ERROR) because it should not happen and indicates a real
> bug. Same for others.

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:112: LOG(WARNING) <<
"TegraV4L2Poll returned -1 ";
On 2014/09/23 08:08:29, wuchengli wrote:
> When this happens, will it keep spamming the logs? We don't want to log this
30
> times per second. Pawel. What's your opinion?

Keep log. Wait Pawel's comment.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:161: LOG(WARNING) << "Unable
to initialize functions ";
On 2014/09/23 08:08:29, wuchengli wrote:
> Help remove extra space at the end of the string.

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/v4l2_image_processor.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:29: DPLOG(ERROR) << __func__ <<
"(): ioctl() failed: " << #type; \
On 2014/09/23 08:08:29, wuchengli wrote:
> Do we want to log this?

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:43: DPLOG(ERROR) << __func__ <<
"(): ioctl() failed: " << #type; \
On 2014/09/23 08:08:29, wuchengli wrote:
> Do we want to log this?

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:113: LOG(WARNING) <<
"Unrecognized format(s)";
On 2014/09/23 08:08:29, wuchengli wrote:
> I don't think this is a real error. The user of this API should decide it.

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:36: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: " << #type; \
On 2014/09/23 08:08:30, wuchengli wrote:
> Do we want to log this?

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:51: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: " << #type; \
On 2014/09/23 08:08:30, wuchengli wrote:
> Do we want to log this?

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:231: LOG(WARNING) <<
"Initialize(): unsupported profile=" << profile;
On 2014/09/23 08:08:30, wuchengli wrote:
> Not a real error. The client can test if a profile is supported. We shouldn't
> log it.

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:968: DPLOG(ERROR) <<
"SetDevicePollInterrupt(): failed";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:990: DPLOG(ERROR) <<
"SetDevicePollInterrupt(): failed";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1046: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1077: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
On 2014/09/23 08:08:29, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1447: DPLOG(ERROR) <<
"SetDevicePollInterrupt(): failed";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1548: DVLOG(3) <<
"Couldn't get format information after resolution change";
On 2014/09/23 08:08:30, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1554: DVLOG(3) <<
"Couldn't reallocate buffers after resolution change";
On 2014/09/23 08:08:30, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1636: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: VIDIOC_G_FMT";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1712: DPLOG(ERROR) <<
"CreateInputBuffers(): mmap() failed";
On 2014/09/23 08:08:29, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1839: DPLOG(ERROR) <<
"DestroyOutputBuffers() ioctl() failed: VIDIOC_REQBUFS";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:31: DPLOG(ERROR) <<
__func__ << "(): ioctl() failed: " << #type; \
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:503: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:531: DPLOG(ERROR) <<
"Dequeue(): ioctl() failed: VIDIOC_DQBUF";
On 2014/09/23 08:08:31, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:1050: DPLOG(ERROR) <<
"CreateOutputBuffers(): mmap() failed";
On 2014/09/23 08:08:30, wuchengli wrote:
> PLOG

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:172: DVLOG(1) <<
"Failed creating an X Pixmap for TFP";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:185: DVLOG(1) <<
"Failed creating a GLX Pixmap for TFP";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:222: DVLOG(1) <<
"Picture id " << picture_buffer_id << " does not exist";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:298: DVLOG(1) <<
"Could not get a usable FBConfig";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:309: DVLOG(1) <<
"Failed initializing VAAPI";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
File content/common/gpu/media/vaapi_video_encode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_encode_accelerator.cc:226: DVLOGF(1) <<
"Failed initializing VAAPI";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/20001/content/common/gpu/media...
content/common/gpu/media/vaapi_video_encode_accelerator.cc:231: DVLOGF(1) <<
"Failed to start encoder thread";
On 2014/09/23 08:08:31, wuchengli wrote:
> LOG(ERROR)

Done.

[Pawel Osciak, 2014-10-01 05:05:00]

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
File content/common/gpu/media/tegra_v4l2_video_device.cc (right):

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:188: return egl_image;
Would be good  to have a LOG(ERROR) here as well.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:190: if
(TegraV4L2_UseEglImage(device_fd_, buffer_index, egl_image) != 0) {
And here too.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
File content/common/gpu/media/v4l2_image_processor.cc (right):

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:113: DLOG(ERROR) <<
"Unrecognized format(s)";
Here?

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1016: LOG(FATAL) <<
"DequeueEvents(): got an event (" << ev.type
Please change this to LOG(ERROR). LOG(FATAL) kills the process.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1161: LOG(FATAL) <<
__func__ << " eglDestroySyncKHR failed!";
Please change this to LOG(ERROR). LOG(FATAL) kills the process.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1854: LOG(FATAL) <<
__func__ << " Failed destroying output buffers.";
Please change this to LOG(ERROR). LOG(FATAL) kills the process.

[Pawel Osciak, 2014-10-01 05:14:23]

Oh and please go over VaapiWrapper too.

[henryhsu, 2014-10-01 05:30:04]

all done. PTAL.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
File content/common/gpu/media/tegra_v4l2_video_device.cc (right):

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:188: return egl_image;
On 2014/10/01 05:05:00, Pawel Osciak wrote:
> Would be good  to have a LOG(ERROR) here as well.

Done.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/tegra_v4l2_video_device.cc:190: if
(TegraV4L2_UseEglImage(device_fd_, buffer_index, egl_image) != 0) {
On 2014/10/01 05:05:00, Pawel Osciak wrote:
> And here too.

Done.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
File content/common/gpu/media/v4l2_image_processor.cc (right):

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_image_processor.cc:113: DLOG(ERROR) <<
"Unrecognized format(s)";
On 2014/10/01 05:05:00, Pawel Osciak wrote:
> Here?

Done.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1016: LOG(FATAL) <<
"DequeueEvents(): got an event (" << ev.type
On 2014/10/01 05:05:00, Pawel Osciak wrote:
> Please change this to LOG(ERROR). LOG(FATAL) kills the process.

Done.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1161: LOG(FATAL) <<
__func__ << " eglDestroySyncKHR failed!";
On 2014/10/01 05:05:00, Pawel Osciak wrote:
> Please change this to LOG(ERROR). LOG(FATAL) kills the process.

Done.

https://codereview.chromium.org/597473002/diff/40001/content/common/gpu/media...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:1854: LOG(FATAL) <<
__func__ << " Failed destroying output buffers.";
On 2014/10/01 05:05:00, Pawel Osciak wrote:
> Please change this to LOG(ERROR). LOG(FATAL) kills the process.

Done.

[Pawel Osciak, 2014-10-02 08:58:54]

Please rebase.

https://chromiumcodereview.appspot.com/597473002/diff/60001/content/common/gp...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://chromiumcodereview.appspot.com/597473002/diff/60001/content/common/gp...
content/common/gpu/media/vaapi_wrapper.cc:201: LOG(ERROR) << "Unsupported
profile";
This is not an ERROR, will happen on devices that don't support a profile
normally.

https://chromiumcodereview.appspot.com/597473002/diff/60001/content/common/gp...
content/common/gpu/media/vaapi_wrapper.cc:229: LOG(ERROR) << "Unsupported
entrypoint";
Ditto.

https://chromiumcodereview.appspot.com/597473002/diff/60001/content/common/gp...
content/common/gpu/media/vaapi_wrapper.cc:258: LOG(ERROR) << "Unsupported value
" << required_attribs[i].value
Also not an error to report.

[henryhsu, 2014-10-02 09:12:47]

all done. PTAL

[Pawel Osciak, 2014-10-03 00:07:39]

Sorry, a few more additional thoughts.
Otherwise lgtm, please feel free to CQ after fixing these.

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
File content/common/gpu/media/tegra_v4l2_video_device.cc (right):

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
content/common/gpu/media/tegra_v4l2_video_device.cc:58: LOG(ERROR) << "Failed to
load libtegrav4l2.so ";
Actually, sorry, I'm changing my mind here, but we should not LOG(ERROR)
failures to load libraries and open Tegra device. This is because we expect this
to fail on non-Tegra as the part of detection which device to use in
V4L2Device::Create.

So here let's keep DLOG please.

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
content/common/gpu/media/tegra_v4l2_video_device.cc:161: LOG(ERROR) << "Unable
to initialize functions";
Here as well.

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
content/common/gpu/media/tegra_v4l2_video_device.cc:167: LOG(ERROR) << "Unable
to open device " << device_path;
And here.

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:873: DVLOG(1) <<
"Unsupported input format";
This should be a LOG(ERROR)

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://chromiumcodereview.appspot.com/597473002/diff/100001/content/common/g...
content/common/gpu/media/vaapi_wrapper.cc:710: DVLOG(1) << "Insufficient output
buffer size";
This should also be a LOG(ERROR)

[henryhsu, 2014-10-03 03:01:30]

all done

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
File content/common/gpu/media/tegra_v4l2_video_device.cc (right):

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
content/common/gpu/media/tegra_v4l2_video_device.cc:58: LOG(ERROR) << "Failed to
load libtegrav4l2.so ";
On 2014/10/03 00:07:39, Pawel Osciak wrote:
> Actually, sorry, I'm changing my mind here, but we should not LOG(ERROR)
> failures to load libraries and open Tegra device. This is because we expect
this
> to fail on non-Tegra as the part of detection which device to use in
> V4L2Device::Create.
> 
> So here let's keep DLOG please.

Done.

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
content/common/gpu/media/tegra_v4l2_video_device.cc:161: LOG(ERROR) << "Unable
to initialize functions";
On 2014/10/03 00:07:39, Pawel Osciak wrote:
> Here as well.

Done.

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
content/common/gpu/media/tegra_v4l2_video_device.cc:167: LOG(ERROR) << "Unable
to open device " << device_path;
On 2014/10/03 00:07:39, Pawel Osciak wrote:
> And here.

Done.

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:873: DVLOG(1) <<
"Unsupported input format";
On 2014/10/03 00:07:39, Pawel Osciak wrote:
> This should be a LOG(ERROR)

Done.

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://codereview.chromium.org/597473002/diff/100001/content/common/gpu/medi...
content/common/gpu/media/vaapi_wrapper.cc:710: DVLOG(1) << "Insufficient output
buffer size";
On 2014/10/03 00:07:39, Pawel Osciak wrote:
> This should also be a LOG(ERROR)

Done.

[henryhsu, 2014-10-03 03:01:44]

The CQ bit was checked by henryhsu@chromium.org

[commit-bot: I haz the power, 2014-10-03 03:02:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597473002/120001

[commit-bot: I haz the power, 2014-10-03 03:33:56]

Committed patchset #7 (id:120001) as 7f8302617c590665a43cd2cba091883108e5c40c

[commit-bot: I haz the power, 2014-10-03 03:34:27]

Patchset 7 (id:??) landed as
https://crrev.com/b1f97630024706465759fb07a5308805b78a0c87
Cr-Commit-Position: refs/heads/master@{#297983}