Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: content/common/gpu/media/vaapi_video_decode_accelerator.cc

Issue 597473002: Change log level to show real errors in release mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/vaapi_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/vaapi_video_decode_accelerator.cc b/content/common/gpu/media/vaapi_video_decode_accelerator.cc
index 0b3001272ac8e8349362fe10fbd4612e5cbc8e3e..df1f6443421d197b67aa31ef61634307175a242d 100644
--- a/content/common/gpu/media/vaapi_video_decode_accelerator.cc
+++ b/content/common/gpu/media/vaapi_video_decode_accelerator.cc
@@ -30,7 +30,7 @@ namespace content {
#define RETURN_AND_NOTIFY_ON_FAILURE(result, log, error_code, ret) \
do { \
if (!(result)) { \
- DVLOG(1) << log; \
+ LOG(ERROR) << log; \
NotifyError(error_code); \
return ret; \
} \
@@ -54,7 +54,7 @@ void VaapiVideoDecodeAccelerator::NotifyError(Error error) {
message_loop_->PostTask(FROM_HERE, base::Bind(
&VaapiVideoDecodeAccelerator::Cleanup, weak_this_));
- DVLOG(1) << "Notifying of error " << error;
+ LOG(ERROR) << "Notifying of error " << error;
if (client_) {
client_->NotifyError(error);
client_ptr_factory_.reset();
@@ -169,7 +169,7 @@ bool VaapiVideoDecodeAccelerator::TFPPicture::Initialize(
x_pixmap_ = XCreatePixmap(x_display_, RootWindow(x_display_, screen),
size_.width(), size_.height(), win_attr.depth);
if (!x_pixmap_) {
- DVLOG(1) << "Failed creating an X Pixmap for TFP";
+ LOG(ERROR) << "Failed creating an X Pixmap for TFP";
return false;
}
@@ -182,7 +182,7 @@ bool VaapiVideoDecodeAccelerator::TFPPicture::Initialize(
glx_pixmap_ = glXCreatePixmap(x_display_, fb_config, x_pixmap_, pixmap_attr);
if (!glx_pixmap_) {
// x_pixmap_ will be freed in the destructor.
- DVLOG(1) << "Failed creating a GLX Pixmap for TFP";
+ LOG(ERROR) << "Failed creating a GLX Pixmap for TFP";
return false;
}
@@ -219,7 +219,7 @@ VaapiVideoDecodeAccelerator::TFPPicture*
VaapiVideoDecodeAccelerator::TFPPictureById(int32 picture_buffer_id) {
TFPPictures::iterator it = tfp_pictures_.find(picture_buffer_id);
if (it == tfp_pictures_.end()) {
- DVLOG(1) << "Picture id " << picture_buffer_id << " does not exist";
+ LOG(ERROR) << "Picture id " << picture_buffer_id << " does not exist";
return NULL;
}
@@ -295,7 +295,7 @@ bool VaapiVideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile,
return false;
if (!InitializeFBConfig()) {
- DVLOG(1) << "Could not get a usable FBConfig";
+ LOG(ERROR) << "Could not get a usable FBConfig";
return false;
}
@@ -306,7 +306,7 @@ bool VaapiVideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile,
base::Bind(&ReportToUMA, content::VaapiH264Decoder::VAAPI_ERROR));
if (!vaapi_wrapper_.get()) {
- DVLOG(1) << "Failed initializing VAAPI";
+ LOG(ERROR) << "Failed initializing VAAPI";
return false;
}
« no previous file with comments | « content/common/gpu/media/v4l2_video_encode_accelerator.cc ('k') | content/common/gpu/media/vaapi_video_encode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698