Issue 5885170347409408: Add location information to watchers to make them more debuggable.

Issue 5885170347409408: Add location information to watchers to make them more debuggable. (Closed)

Created:
7 years, 5 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web-ui.git@master

Visibility:
Public.

More Reviews

Description

Add location information to watchers to make them more debuggable. R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/73d197e

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+272 lines, -108 lines)			Patch
M	lib/src/compiler.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/templating.dart	View	1 2 3	5 chunks	+57 lines, -81 lines	0 comments	Download
M	lib/testing/render_test.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/watcher.dart	View	1 2 3	15 chunks	+92 lines, -26 lines	0 comments	Download
M	pubspec.yaml	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/watcher_test.dart	View	1 2 3	2 chunks	+116 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

This change makes it possible to record stack-trace information when registering watchers so that it ...

7 years, 5 months ago (2013-07-11 21:22:33 UTC) #1

Jennifer Messerly

lgtm https://chromiumcodereview.appspot.com/5885170347409408/diff/5785905063264256/lib/templating.dart File lib/templating.dart (right): https://chromiumcodereview.appspot.com/5885170347409408/diff/5785905063264256/lib/templating.dart#newcode659 lib/templating.dart:659: return trace.toString(); use http://pub.dartlang.org/packages/stack_trace ? https://chromiumcodereview.appspot.com/5885170347409408/diff/5785905063264256/lib/watcher.dart File lib/watcher.dart ...

7 years, 5 months ago (2013-07-11 21:27:23 UTC) #2

Siggi Cherem (dart-lang)

thanks! https://chromiumcodereview.appspot.com/5885170347409408/diff/5785905063264256/lib/templating.dart File lib/templating.dart (right): https://chromiumcodereview.appspot.com/5885170347409408/diff/5785905063264256/lib/templating.dart#newcode659 lib/templating.dart:659: return trace.toString(); On 2013/07/11 21:27:23, John Messerly wrote: ...

7 years, 5 months ago (2013-07-11 22:07:01 UTC) #3

Siggi Cherem (dart-lang)

7 years, 5 months ago (2013-07-11 23:08:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r73d197e (presubmit successful).

Expand Messages | Collapse Messages