Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4610)

Unified Diff: chrome/browser/extensions/extension_process_manager.h

Issue 57923009: Move ExtensionProcessManager to src/extensions, part 3 - remove Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.h
diff --git a/chrome/browser/extensions/extension_process_manager.h b/chrome/browser/extensions/extension_process_manager.h
index 2b7273f9e92adc87ddda9ae15ba66235f9d4e68e..10f6455947db41da951e31473202a90bea830ae1 100644
--- a/chrome/browser/extensions/extension_process_manager.h
+++ b/chrome/browser/extensions/extension_process_manager.h
@@ -18,7 +18,6 @@
#include "content/public/browser/notification_registrar.h"
#include "extensions/common/view_type.h"
-class Browser;
class GURL;
namespace content {
@@ -51,30 +50,6 @@ class ExtensionProcessManager : public content::NotificationObserver {
typedef std::set<content::RenderViewHost*> ViewSet;
const ViewSet GetAllViews() const;
- // Creates a new ExtensionHost with its associated view, grouping it in the
- // appropriate SiteInstance (and therefore process) based on the URL and
- // profile.
- virtual extensions::ExtensionHost* CreateViewHost(
- const extensions::Extension* extension,
- const GURL& url,
- Browser* browser,
- extensions::ViewType view_type);
- extensions::ExtensionHost* CreateViewHost(const GURL& url,
- Browser* browser,
- extensions::ViewType view_type);
- extensions::ExtensionHost* CreatePopupHost(
- const extensions::Extension* extension,
- const GURL& url,
- Browser* browser);
- extensions::ExtensionHost* CreatePopupHost(const GURL& url, Browser* browser);
- extensions::ExtensionHost* CreateDialogHost(const GURL& url);
- extensions::ExtensionHost* CreateInfobarHost(
- const extensions::Extension* extension,
- const GURL& url,
- Browser* browser);
- extensions::ExtensionHost* CreateInfobarHost(const GURL& url,
- Browser* browser);
-
// Creates a new UI-less extension instance. Like CreateViewHost, but not
// displayed anywhere.
virtual extensions::ExtensionHost* CreateBackgroundHost(
@@ -143,6 +118,9 @@ class ExtensionProcessManager : public content::NotificationObserver {
// Ensures background hosts are loaded for a new browser window.
void OnBrowserWindowReady();
+ // Called just after |host| is created so it can be registered in our lists.
+ void OnExtensionHostCreated(extensions::ExtensionHost* host);
Yoyo Zhou 2013/11/06 19:08:07 Can you rename this to OnBackgroundHostCreated and
+
// Gets the BrowserContext associated with site_instance_ and all other
// related SiteInstances.
content::BrowserContext* GetBrowserContext() const;
@@ -153,10 +131,6 @@ class ExtensionProcessManager : public content::NotificationObserver {
ExtensionProcessManager(content::BrowserContext* context,
content::BrowserContext* original_context);
- // Called just after |host| is created so it can be registered in our lists.
- void OnExtensionHostCreated(extensions::ExtensionHost* host,
- bool is_background);
-
// Called on browser shutdown to close our extension hosts.
void CloseBackgroundHosts();
@@ -192,10 +166,6 @@ class ExtensionProcessManager : public content::NotificationObserver {
// Close the given |host| iff it's a background page.
void CloseBackgroundHost(extensions::ExtensionHost* host);
- // Ensure browser object is not null except for certain situations.
- void EnsureBrowserWhenRequired(Browser* browser,
- extensions::ViewType view_type);
-
// These are called when the extension transitions between idle and active.
// They control the process of closing the background page when idle.
void OnLazyBackgroundPageIdle(const std::string& extension_id,
« no previous file with comments | « chrome/browser/extensions/extension_infobar_delegate.cc ('k') | chrome/browser/extensions/extension_process_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698