Move ExtensionProcessManager to src/extensions, part 3 - remove Browser

chrome/browser/extensions/extension_process_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PROCESS_MANAGER_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PROCESS_MANAGER_H_
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "extensions/common/view_type.h"
 
-class Browser;
 class GURL;
 
 namespace content {
 class BrowserContext;
 class DevToolsAgentHost;
 class RenderViewHost;
 class SiteInstance;
 };
 
 namespace extensions {
@@ skipping 12 matching lines @@
   static ExtensionProcessManager* Create(content::BrowserContext* context);
   virtual ~ExtensionProcessManager();
 
   const ExtensionHostSet& background_hosts() const {
     return background_hosts_;
   }
 
   typedef std::set<content::RenderViewHost*> ViewSet;
   const ViewSet GetAllViews() const;
 
-  // Creates a new ExtensionHost with its associated view, grouping it in the
-  // appropriate SiteInstance (and therefore process) based on the URL and
-  // profile.
-  virtual extensions::ExtensionHost* CreateViewHost(
-      const extensions::Extension* extension,
-      const GURL& url,
-      Browser* browser,
-      extensions::ViewType view_type);
-  extensions::ExtensionHost* CreateViewHost(const GURL& url,
-                                            Browser* browser,
-                                            extensions::ViewType view_type);
-  extensions::ExtensionHost* CreatePopupHost(
-      const extensions::Extension* extension,
-      const GURL& url,
-      Browser* browser);
-  extensions::ExtensionHost* CreatePopupHost(const GURL& url, Browser* browser);
-  extensions::ExtensionHost* CreateDialogHost(const GURL& url);
-  extensions::ExtensionHost* CreateInfobarHost(
-      const extensions::Extension* extension,
-      const GURL& url,
-      Browser* browser);
-  extensions::ExtensionHost* CreateInfobarHost(const GURL& url,
-                                               Browser* browser);
-
   // Creates a new UI-less extension instance.  Like CreateViewHost, but not
   // displayed anywhere.
   virtual extensions::ExtensionHost* CreateBackgroundHost(
       const extensions::Extension* extension,
       const GURL& url);
 
   // Gets the ExtensionHost for the background page for an extension, or NULL if
   // the extension isn't running or doesn't have a background page.
   extensions::ExtensionHost* GetBackgroundHostForExtension(
       const std::string& extension_id);
@@ skipping 48 matching lines @@
   void CancelSuspend(const extensions::Extension* extension);
 
   // If |defer| is true background host creation is to be deferred until this is
   // called again with |defer| set to false, at which point all deferred
   // background hosts will be created.  Defaults to false.
   void DeferBackgroundHostCreation(bool defer);
 
   // Ensures background hosts are loaded for a new browser window.
   void OnBrowserWindowReady();
 
+  // Called just after |host| is created so it can be registered in our lists.
+  void OnExtensionHostCreated(extensions::ExtensionHost* host);

[Yoyo Zhou, 2013/11/06 19:08:07]

Can you rename this to OnBackgroundHostCreated and move it back to protected?

+
   // Gets the BrowserContext associated with site_instance_ and all other
   // related SiteInstances.
   content::BrowserContext* GetBrowserContext() const;
 
  protected:
   // If |context| is incognito pass the master context as |original_context|.
   // Otherwise pass the same context for both.
   ExtensionProcessManager(content::BrowserContext* context,
                           content::BrowserContext* original_context);
 
-  // Called just after |host| is created so it can be registered in our lists.
-  void OnExtensionHostCreated(extensions::ExtensionHost* host,
-                              bool is_background);
-
   // Called on browser shutdown to close our extension hosts.
   void CloseBackgroundHosts();
 
   // content::NotificationObserver:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // Load all background pages once the profile data is ready and the pages
   // should be loaded.
@@ skipping 15 matching lines @@
   // Extra information we keep for each extension's background page.
   struct BackgroundPageData;
   typedef std::string ExtensionId;
   typedef std::map<ExtensionId, BackgroundPageData> BackgroundPageDataMap;
   typedef std::map<content::RenderViewHost*,
       extensions::ViewType> ExtensionRenderViews;
 
   // Close the given |host| iff it's a background page.
   void CloseBackgroundHost(extensions::ExtensionHost* host);
 
-  // Ensure browser object is not null except for certain situations.
-  void EnsureBrowserWhenRequired(Browser* browser,
-                                 extensions::ViewType view_type);
-
   // These are called when the extension transitions between idle and active.
   // They control the process of closing the background page when idle.
   void OnLazyBackgroundPageIdle(const std::string& extension_id,
                                 int sequence_id);
   void OnLazyBackgroundPageActive(const std::string& extension_id);
   void CloseLazyBackgroundPageNow(const std::string& extension_id,
                                   int sequence_id);
 
   // Potentially registers a RenderViewHost, if it is associated with an
   // extension. Does nothing if this is not an extension renderer.
@@ skipping 33 matching lines @@
   bool startup_background_hosts_created_;
 
   base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_;
 
   base::WeakPtrFactory<ExtensionProcessManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionProcessManager);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PROCESS_MANAGER_H_