Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57923009: Move ExtensionProcessManager to src/extensions, part 3 - remove Browser (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move ExtensionProcessManager to src/extensions, part 3 - remove Browser Introduce ExtensionHostFactory to hold Browser-specific ExtensionHost creation. BUG=313481 TEST=browser_tests, unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233504

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add test #

Total comments: 1

Patch Set 4 : rebase #

Total comments: 4

Patch Set 5 : remove OnExtensionHostCreated call #

Patch Set 6 : cleanup #

Total comments: 1

Patch Set 7 : OnBackgroundHostCreated #

Patch Set 8 : rebase #

Patch Set 9 : rebase, fix incognito_info include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -200 lines) Patch
A chrome/browser/extensions/extension_host_factory.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_host_factory.cc View 1 2 3 4 5 6 7 8 1 chunk +144 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_host_factory_browsertest.cc View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 1 2 3 4 5 6 4 chunks +3 lines, -33 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 2 3 4 5 6 7 8 6 chunks +12 lines, -118 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
yoz, PTAL https://codereview.chromium.org/57923009/diff/40001/chrome/browser/extensions/extension_host_factory.cc File chrome/browser/extensions/extension_host_factory.cc (right): https://codereview.chromium.org/57923009/diff/40001/chrome/browser/extensions/extension_host_factory.cc#newcode71 chrome/browser/extensions/extension_host_factory.cc:71: return CreateViewHostForExtension( This is the behavior of ...
7 years, 1 month ago (2013-11-05 22:52:27 UTC) #1
James Cook
https://codereview.chromium.org/57923009/diff/140001/chrome/browser/extensions/extension_host_factory.cc File chrome/browser/extensions/extension_host_factory.cc (right): https://codereview.chromium.org/57923009/diff/140001/chrome/browser/extensions/extension_host_factory.cc#newcode71 chrome/browser/extensions/extension_host_factory.cc:71: return CreateViewHostForExtension( This is the behavior of the original ...
7 years, 1 month ago (2013-11-06 00:16:40 UTC) #2
Yoyo Zhou
https://chromiumcodereview.appspot.com/57923009/diff/140001/chrome/browser/extensions/extension_host_factory.cc File chrome/browser/extensions/extension_host_factory.cc (right): https://chromiumcodereview.appspot.com/57923009/diff/140001/chrome/browser/extensions/extension_host_factory.cc#newcode47 chrome/browser/extensions/extension_host_factory.cc:47: pm->OnExtensionHostCreated(host, false); I'm not sure we need this. It's ...
7 years, 1 month ago (2013-11-06 03:24:47 UTC) #3
James Cook
yoz, please take another look sky, can I get OWNERS approval for chrome/browser/ui/ ? This ...
7 years, 1 month ago (2013-11-06 16:50:33 UTC) #4
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/57923009/diff/340001/chrome/browser/extensions/extension_process_manager.h File chrome/browser/extensions/extension_process_manager.h (right): https://chromiumcodereview.appspot.com/57923009/diff/340001/chrome/browser/extensions/extension_process_manager.h#newcode122 chrome/browser/extensions/extension_process_manager.h:122: void OnExtensionHostCreated(extensions::ExtensionHost* host); Can you rename this to ...
7 years, 1 month ago (2013-11-06 19:08:07 UTC) #5
sky
LGTM
7 years, 1 month ago (2013-11-06 21:17:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/57923009/520001
7 years, 1 month ago (2013-11-06 22:47:53 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 06:29:25 UTC) #8
Message was sent while issue was closed. 
Change committed as 233504

Powered by Google App Engine
This is Rietveld 408576698