Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 57843006: Run google_apis_unittests on mac master. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : alphabetical changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M masters/master.chromium.mac/master_gatekeeper_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.mac/master_mac_cfg.py View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
Based on https://chromiumcodereview.appspot.com/11967037
7 years, 1 month ago (2013-11-05 02:13:00 UTC) #1
Jói
LGTM On Tue, Nov 5, 2013 at 2:13 AM, <tfarina@chromium.org> wrote: > Reviewers: Jói, stip, ...
7 years, 1 month ago (2013-11-05 10:16:33 UTC) #2
ghost stip (do not use)
please add these tests to the corresponding tryserver builders. then we can cut a CL ...
7 years, 1 month ago (2013-11-05 21:37:35 UTC) #3
tfarina
On 2013/11/05 21:37:35, stip wrote: > please add these tests to the corresponding tryserver builders. ...
7 years, 1 month ago (2013-11-05 21:51:43 UTC) #4
ghost stip (do not use)
Ah sorry, that was a while back. lgtm
7 years, 1 month ago (2013-11-05 22:36:31 UTC) #5
ghost stip (do not use)
(with the alphabetical changes)
7 years, 1 month ago (2013-11-05 22:36:56 UTC) #6
tfarina
Pushing the trigger. https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromium.mac/master_mac_cfg.py File masters/master.chromium.mac/master_mac_cfg.py (right): https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromium.mac/master_mac_cfg.py#newcode33 masters/master.chromium.mac/master_mac_cfg.py:33: 'chromedriver2_unittests', On 2013/11/05 21:37:35, stip wrote: ...
7 years, 1 month ago (2013-11-05 23:57:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57843006/110001
7 years, 1 month ago (2013-11-05 23:58:01 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 23:58:46 UTC) #9
Message was sent while issue was closed.
Change committed as 233144

Powered by Google App Engine
This is Rietveld 408576698