Run google_apis_unittests on mac master.

Run google_apis_unittests on mac master.

BUG=257421
R=stip@chromium.org,joi@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=233144

[tfarina, 2013-11-05 02:13:00]

Based on https://chromiumcodereview.appspot.com/11967037

[Jói, 2013-11-05 10:16:33]

LGTM


On Tue, Nov 5, 2013 at 2:13 AM, <tfarina@chromium.org> wrote:

> Reviewers: Jói, stip,
>
> Message:
> Based on https://chromiumcodereview.appspot.com/11967037
>
> Description:
> Run google_apis_unittests on mac master.
>
> BUG=257421
> R=stip@chromium.org,joi@chromium.org
>
> Please review this at https://codereview.chromium.org/57843006/
>
> SVN Base: https://chromium.googlesource.com/chromium/tools/build@master
>
> Affected files (+5, -1 lines):
>   M masters/master.chromium.mac/master_gatekeeper_cfg.py
>   M masters/master.chromium.mac/master_mac_cfg.py
>
>
> Index: masters/master.chromium.mac/master_gatekeeper_cfg.py
> diff --git a/masters/master.chromium.mac/master_gatekeeper_cfg.py
> b/masters/master.chromium.mac/master_gatekeeper_cfg.py
> index 5a57a7151f2565832e3400a239ceb73db147c9c0..
> bfebcf55f4a2556ea859d833586acdf5efed75f3 100644
> --- a/masters/master.chromium.mac/master_gatekeeper_cfg.py
> +++ b/masters/master.chromium.mac/master_gatekeeper_cfg.py
> @@ -26,6 +26,7 @@ categories_steps = {
>      'courgette_unittests',
>      'crypto_unittests',
>      'device_unittests',
> +    'google_apis_unittests',
>      'installer_util_unittests',
>      'interactive_ui_tests',
>      'ipc_tests',
> Index: masters/master.chromium.mac/master_mac_cfg.py
> diff --git a/masters/master.chromium.mac/master_mac_cfg.py
> b/masters/master.chromium.mac/master_mac_cfg.py
> index 1f125fdd87dd9bc4c52250e33615e2bcb45c7b16..
> d0ab62fe4a12a1355da31c6885f7adacf35ceed7 100644
> --- a/masters/master.chromium.mac/master_mac_cfg.py
> +++ b/masters/master.chromium.mac/master_mac_cfg.py
> @@ -30,13 +30,14 @@ sharded_tests = [
>    'browser_tests',
>    'cacheinvalidation_unittests',
>    'cc_unittests',
> -  'chromedriver_tests',
>    'chromedriver2_unittests',
> +  'chromedriver_tests',
>    'components_unittests',
>    'content_browsertests',
>    'content_unittests',
>    'crypto_unittests',
>    'device_unittests',
> +  'google_apis_unittests',
>    'gpu_unittests',
>    'jingle_unittests',
>    'media_unittests',
> @@ -125,6 +126,7 @@ F('rel_unit_2', mac_tester().ChromiumFactory(
>    build_url=rel_archive,
>    tests=[
>      'browser_tests',
> +    'google_apis_unittests',
>      'components_unittests',
>      'unit',
>    ],
> @@ -271,6 +273,7 @@ F('dbg_unit_4', mac_tester().ChromiumFactory(
>    tests=[
>      'browser_tests',
>      'components_unittests',
> +    'google_apis_unittests',
>      'unit',
>      'message_center_unittests',
>    ],
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ghost stip (do not use), 2013-11-05 21:37:35]

please add these tests to the corresponding tryserver builders. then we can cut
a CL for CQ's projects.py that enables these tests for CQ, then restart CQ and
the TS simultaneously

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
File masters/master.chromium.mac/master_gatekeeper_cfg.py (right):

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
masters/master.chromium.mac/master_gatekeeper_cfg.py:29:
'google_apis_unittests',
if this is going to close the tree, we'll need to add it to projects.py in CQ as
well

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
File masters/master.chromium.mac/master_mac_cfg.py (right):

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
masters/master.chromium.mac/master_mac_cfg.py:33: 'chromedriver2_unittests',
why the switch? it should be below chromedriver_tests to keep alphabetical order

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
masters/master.chromium.mac/master_mac_cfg.py:129: 'google_apis_unittests',
alphabetical

[tfarina, 2013-11-05 21:51:43]

On 2013/11/05 21:37:35, stip wrote:
> please add these tests to the corresponding tryserver builders.
I think I added it https://codereview.chromium.org/27130002

Otherwise could you point me to the source file where I should add them? I have
no idea where they are.

[ghost stip (do not use), 2013-11-05 22:36:31]

Ah sorry, that was a while back. lgtm

[ghost stip (do not use), 2013-11-05 22:36:56]

(with the alphabetical changes)

[tfarina, 2013-11-05 23:57:51]

Pushing the trigger.

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
File masters/master.chromium.mac/master_mac_cfg.py (right):

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
masters/master.chromium.mac/master_mac_cfg.py:33: 'chromedriver2_unittests',
On 2013/11/05 21:37:35, stip wrote:
> why the switch? it should be below chromedriver_tests to keep alphabetical
order

it was vim sort, I have LANG=C in my .bashrc. Must be some oddities of my
environment.

reverted.

https://chromiumcodereview.appspot.com/57843006/diff/1/masters/master.chromiu...
masters/master.chromium.mac/master_mac_cfg.py:129: 'google_apis_unittests',
On 2013/11/05 21:37:35, stip wrote:
> alphabetical

Done.

[commit-bot: I haz the power, 2013-11-05 23:58:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/57843006/110001

[commit-bot: I haz the power, 2013-11-05 23:58:46]

Change committed as 233144