Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issue 11967037: Run components_unittests on mac master (Closed)

Created:
7 years, 11 months ago by kaiwang
Modified:
7 years, 11 months ago
CC:
chromium-reviews, cmp+cc_chromium.org
Base URL:
https://git.chromium.org/chromium/tools/build.git@master
Visibility:
Public.

Description

Run components_unittests on mac master BUG=170191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M masters/master.chromium.mac/master_gatekeeper_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.mac/master_mac_cfg.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kaiwang
7 years, 11 months ago (2013-01-17 05:01:27 UTC) #1
iannucci
lgtm
7 years, 11 months ago (2013-01-17 19:38:39 UTC) #2
Mike Stip (use stip instead)
lgtm
7 years, 11 months ago (2013-01-18 00:08:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11967037/1
7 years, 11 months ago (2013-01-18 03:44:08 UTC) #4
commit-bot: I haz the power
Couldn't make sense out of svn commit message: Sending build/masters/master.chromium.mac/master_gatekeeper_cfg.py Sending build/masters/master.chromium.mac/master_mac_cfg.py Transmitting file data ...
7 years, 11 months ago (2013-01-18 03:56:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11967037/1
7 years, 11 months ago (2013-01-18 03:59:47 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 03:59:49 UTC) #7
Failed to apply patch for
build/masters/master.chromium.mac/master_gatekeeper_cfg.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/masters/master.chromium.mac/master_gatekeeper_cfg.py
  Hunk #1 FAILED at 19.
  1 out of 1 hunk FAILED -- saving rejects to file
build/masters/master.chromium.mac/master_gatekeeper_cfg.py.rej

Patch:       build/masters/master.chromium.mac/master_gatekeeper_cfg.py
Index: masters/master.chromium.mac/master_gatekeeper_cfg.py
diff --git build/masters/master.chromium.mac/master_gatekeeper_cfg.py
build/masters/master.chromium.mac/master_gatekeeper_cfg.py
index
e294454273ef579dd2bb2d1bfe52da39356d2464..6d6455076d8437ff7eedd0a7bccf286470e85e4d
100644
--- a/build/masters/master.chromium.mac/master_gatekeeper_cfg.py
+++ b/build/masters/master.chromium.mac/master_gatekeeper_cfg.py
@@ -19,6 +19,7 @@ categories_steps = {
     'cc_unittests',
     'chrome_frame_net_tests',
     'chromedriver2_unittests',
+    'components_unittests',
     'content_browsertests',
     'content_unittests',
     'courgette_unittests',

Powered by Google App Engine
This is Rietveld 408576698