Compile print_preview, part 2: reduce down to 260 errors

chrome/browser/resources/print_preview/data/destination_store.js

Index: chrome/browser/resources/print_preview/data/destination_store.js
diff --git a/chrome/browser/resources/print_preview/data/destination_store.js b/chrome/browser/resources/print_preview/data/destination_store.js
index 8f3a108f782ebd4daa9622e0a3730e3d963f9b67..627dd4add1f91ba3cf8ae2267b75d78c12cfe29f 100644
--- a/chrome/browser/resources/print_preview/data/destination_store.js
+++ b/chrome/browser/resources/print_preview/data/destination_store.js
@@ -55,7 +55,7 @@ cr.define('print_preview', function() {
 
     /**
      * Cache used for constant lookup of destinations by origin and id.
-     * @type {object.<string, !print_preview.Destination>}
+     * @type {Object.<string, !print_preview.Destination>}
      * @private
      */
     this.destinationMap_ = {};
@@ -92,7 +92,7 @@ cr.define('print_preview', function() {
 
     /**
      * Used to fetch cloud-based print destinations.
-     * @type {print_preview.CloudPrintInterface}
+     * @type {cloudprint.CloudPrintInterface}
      * @private
      */
     this.cloudPrintInterface_ = null;
@@ -271,7 +271,7 @@ cr.define('print_preview', function() {
      * @return {boolean} Whether a search for cloud destinations is in progress.
      */
     get isCloudDestinationSearchInProgress() {
-      return this.cloudPrintInterface_ &&
+      return !!this.cloudPrintInterface_ &&

[Lei Zhang, 2014/09/19 00:54:20]

Is there a preference between !!foo vs. foo != null ?

[Vitaly Pavlenko, 2014/09/19 00:57:59]

I just insert the general !! cast in all cases. I don't know if it's a good idea
to do so here. Aleksey, what do you think?

[Aleksey Shlyapnikov, 2014/09/19 18:54:42]

This is a pointer check, why would we convert it to boolean? Same semantics,
more code. Let's leave it as it was.

[Vitaly Pavlenko, 2014/09/19 20:33:09]

Otherwise Closure Compiler whines that we possibly return non-boolean from
function that is supposed to return boolean type.

              this.cloudPrintInterface_.isCloudDestinationSearchInProgress;
     },
 
@@ -343,7 +343,7 @@ cr.define('print_preview', function() {
 
     /**
      * Sets the destination store's Google Cloud Print interface.
-     * @param {!print_preview.CloudPrintInterface} cloudPrintInterface Interface
+     * @param {!cloudprint.CloudPrintInterface} cloudPrintInterface Interface
      *     to set.
      */
     setCloudPrintInterface: function(cloudPrintInterface) {
@@ -380,7 +380,7 @@ cr.define('print_preview', function() {
     },
 
     /**
-     * @param {!print_preview.Destination} destination Destination to select.
+     * @param {print_preview.Destination} destination Destination to select.
      */
     selectDestination: function(destination) {
       this.isInAutoSelectMode_ = false;
@@ -823,7 +823,7 @@ cr.define('print_preview', function() {
      * Called when the Google Cloud Print interface fails to lookup a
      * destination. Selects another destination if the failed destination was
      * the initial destination.
-     * @param {object} event Contains the ID of the destination that was failed
+     * @param {Object} event Contains the ID of the destination that was failed
      *     to be looked up.
      * @private
      */
@@ -839,7 +839,7 @@ cr.define('print_preview', function() {
 
     /**
      * Called when a Privet printer is added to the local network.
-     * @param {object} event Contains information about the added printer.
+     * @param {Object} event Contains information about the added printer.
      * @private
      */
     onPrivetPrinterAdded_: function(event) {
@@ -855,7 +855,7 @@ cr.define('print_preview', function() {
 
     /**
      * Called when capabilities for a privet printer are set.
-     * @param {object} event Contains the capabilities and printer ID.
+     * @param {Object} event Contains the capabilities and printer ID.
      * @private
      */
     onPrivetCapabilitiesSet_: function(event) {
@@ -887,8 +887,8 @@ cr.define('print_preview', function() {
     /**
      * Returns key to be used with {@code destinationMap_}.
      * @param {!print_preview.Destination.Origin} origin Destination origin.
-     * @return {string} id Destination id.
-     * @return {string} account User account destination is registered for.
+     * @param {string} id Destination id.
+     * @param {string} account User account destination is registered for.
      * @private
      */
     getDestinationKey_: function(origin, id, account) {