Compile print_preview, part 2: reduce down to 260 errors

chrome/browser/resources/print_preview/data/app_state.js

Index: chrome/browser/resources/print_preview/data/app_state.js
diff --git a/chrome/browser/resources/print_preview/data/app_state.js b/chrome/browser/resources/print_preview/data/app_state.js
index ffdda9a13c1ee6b79735bd8469470af02b1377e4..230ad3ea607c21677fa82cac63b229fc9e5f67e1 100644
--- a/chrome/browser/resources/print_preview/data/app_state.js
+++ b/chrome/browser/resources/print_preview/data/app_state.js
@@ -29,30 +29,6 @@ cr.define('print_preview', function() {
   };
 
   /**
-   * Enumeration of field names for serialized app state.
-   * @enum {string}
-   */
-  AppState.Field = {
-    VERSION: 'version',
-    SELECTED_DESTINATION_ID: 'selectedDestinationId',
-    SELECTED_DESTINATION_ACCOUNT: 'selectedDestinationAccount',
-    SELECTED_DESTINATION_ORIGIN: 'selectedDestinationOrigin',
-    SELECTED_DESTINATION_CAPABILITIES: 'selectedDestinationCapabilities',
-    SELECTED_DESTINATION_NAME: 'selectedDestinationName',
-    IS_GCP_PROMO_DISMISSED: 'isGcpPromoDismissed',
-    MEDIA_SIZE: 'mediaSize',
-    MARGINS_TYPE: 'marginsType',
-    CUSTOM_MARGINS: 'customMargins',
-    IS_COLOR_ENABLED: 'isColorEnabled',
-    IS_DUPLEX_ENABLED: 'isDuplexEnabled',
-    IS_HEADER_FOOTER_ENABLED: 'isHeaderFooterEnabled',
-    IS_LANDSCAPE_ENABLED: 'isLandscapeEnabled',
-    IS_COLLATE_ENABLED: 'isCollateEnabled',
-    IS_CSS_BACKGROUND_ENABLED: 'isCssBackgroundEnabled',
-    VENDOR_OPTIONS: 'vendorOptions'
-  };
-
-  /**
    * Current version of the app state. This value helps to understand how to
    * parse earlier versions of the app state.
    * @type {number}
@@ -218,3 +194,27 @@ cr.define('print_preview', function() {
     AppState: AppState
   };
 });
+
+/**
+ * Enumeration of field names for serialized app state.
+ * @enum {string}
+ */
+print_preview.AppState.Field = {
+  VERSION: 'version',
+  SELECTED_DESTINATION_ID: 'selectedDestinationId',
+  SELECTED_DESTINATION_ACCOUNT: 'selectedDestinationAccount',
+  SELECTED_DESTINATION_ORIGIN: 'selectedDestinationOrigin',
+  SELECTED_DESTINATION_CAPABILITIES: 'selectedDestinationCapabilities',
+  SELECTED_DESTINATION_NAME: 'selectedDestinationName',
+  IS_GCP_PROMO_DISMISSED: 'isGcpPromoDismissed',
+  MEDIA_SIZE: 'mediaSize',
+  MARGINS_TYPE: 'marginsType',
+  CUSTOM_MARGINS: 'customMargins',
+  IS_COLOR_ENABLED: 'isColorEnabled',
+  IS_DUPLEX_ENABLED: 'isDuplexEnabled',
+  IS_HEADER_FOOTER_ENABLED: 'isHeaderFooterEnabled',
+  IS_LANDSCAPE_ENABLED: 'isLandscapeEnabled',
+  IS_COLLATE_ENABLED: 'isCollateEnabled',
+  IS_CSS_BACKGROUND_ENABLED: 'isCssBackgroundEnabled',
+  VENDOR_OPTIONS: 'vendorOptions'
+};

[Aleksey Shlyapnikov, 2014/09/19 18:54:42]

What's the reason for this and other similar changes?

[Vitaly Pavlenko, 2014/09/19 20:33:09]

Right now Closure Compiler doesn't understand @typedefs and @enums if they are
placed inside function scope:
https://github.com/google/closure-compiler/issues/544

So I need to move them to a global scope to make the typechecking work.