Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/BUILD.gn

Issue 569623002: Switch ChromeOS Chromium login to use IJG libjpeg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on ToT Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | ui/gfx/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/BUILD.gn
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index 8c223ae92076f773733f2624573ce65a01cb2d85..8dca5776f9954b3ea1f9a6ce297b717949503c63 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -20,7 +20,12 @@ config("system_libjpeg_config") {
}
config("libjpeg_turbo_config") {
- defines = [ "USE_LIBJPEG_TURBO" ]
+ # Only used by ui/gfx/codec/jpeg_codec.cc. Chrome OS requires IJG for
+ # robustly decoding login screen images.
+ # TODO(jorgelo): make sure this works on Chrome OS.
+ if (!is_chromeos) {
sky 2014/10/06 18:21:28 Wouldn't it be better to wrap the config in the if
Ed Baker 2014/10/30 23:29:48 Done.
+ defines = [ "USE_LIBJPEG_TURBO" ]
+ }
}
# This is a meta target that forwards to the system's libjpeg,
« no previous file with comments | « build/common.gypi ('k') | ui/gfx/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698