Switch ChromeOS Chromium login to use IJG libjpeg

third_party/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
 declare_args() {
   # Uses system libjpeg. If true, overrides use_libjpeg_turbo.
   use_system_libjpeg = false
 
   # Uses libjpeg_turbo as the jpeg implementation. Has no effect if
   # use_system_libjpeg is set.
   use_libjpeg_turbo = true
 }
 
 config("system_libjpeg_config") {
   defines = [ "USE_SYSTEM_LIBJPEG" ]
 }
 
 config("libjpeg_turbo_config") {
-  defines = [ "USE_LIBJPEG_TURBO" ]
+  # Only used by ui/gfx/codec/jpeg_codec.cc. Chrome OS requires IJG for
+  # robustly decoding login screen images.
+  # TODO(jorgelo): make sure this works on Chrome OS.
+  if (!is_chromeos) {

[sky, 2014/10/06 18:21:28]

Wouldn't it be better to wrap the config in the ifdef?

[Ed Baker, 2014/10/30 23:29:48]

Done.

+    defines = [ "USE_LIBJPEG_TURBO" ]
+  }
 }
 
 # This is a meta target that forwards to the system's libjpeg,
 # third_party/libjpeg, or third_party/libjpeg_turbo depending on the build args
 # declared in this file.
 group("jpeg") {
   if (use_system_libjpeg) {
     libs = [ "jpeg" ]
     direct_dependent_configs = [ ":system_libjpeg_config" ]
   } else if (use_libjpeg_turbo) {
     deps = [ "//third_party/libjpeg_turbo:libjpeg" ]
     direct_dependent_configs = [ ":libjpeg_turbo_config" ]
   } else {
     deps = [ "//third_party/libjpeg:libjpeg" ]
   }
 }