Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: extensions/common/test_util.h

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/test_util.h
diff --git a/extensions/common/test_util.h b/extensions/common/test_util.h
index 46ac5d08c3f266ee773e84ed878a611a3b16dd74..83a09047e74deeb54e3ebf2e05849c8f2d15a013 100644
--- a/extensions/common/test_util.h
+++ b/extensions/common/test_util.h
@@ -27,8 +27,9 @@ ExtensionBuilder& BuildExtension(ExtensionBuilder& builder);
// before running it.
scoped_refptr<Extension> CreateEmptyExtension();
-// Return a very simple extension with a given |id|.
-scoped_refptr<Extension> CreateExtensionWithID(const std::string& id);
+// Create an extension with a variable |id|, for tests that require multiple
+// extensions side-by-side having distinct IDs.
+scoped_refptr<Extension> CreateEmptyExtension(const std::string& id);
// Parses |json| allowing trailing commas and replacing single quotes with
// double quotes for test readability. If the json fails to parse, calls gtest's

Powered by Google App Engine
This is Rietveld 408576698