Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: extensions/common/test_util.h

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_TEST_UTIL_H_ 5 #ifndef EXTENSIONS_COMMON_TEST_UTIL_H_
6 #define EXTENSIONS_COMMON_TEST_UTIL_H_ 6 #define EXTENSIONS_COMMON_TEST_UTIL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 12
13 namespace base { 13 namespace base {
14 class DictionaryValue; 14 class DictionaryValue;
15 } // namespace base 15 } // namespace base
16 16
17 namespace extensions { 17 namespace extensions {
18 class Extension; 18 class Extension;
19 class ExtensionBuilder; 19 class ExtensionBuilder;
20 20
21 namespace test_util { 21 namespace test_util {
22 22
23 // Adds an extension manifest to a builder. 23 // Adds an extension manifest to a builder.
24 ExtensionBuilder& BuildExtension(ExtensionBuilder& builder); 24 ExtensionBuilder& BuildExtension(ExtensionBuilder& builder);
25 25
26 // Creates an extension instance that can be attached to an ExtensionFunction 26 // Creates an extension instance that can be attached to an ExtensionFunction
27 // before running it. 27 // before running it.
28 scoped_refptr<Extension> CreateEmptyExtension(); 28 scoped_refptr<Extension> CreateEmptyExtension();
29 29
30 // Return a very simple extension with a given |id|. 30 // Create an extension with a variable |id|, for tests that require multiple
31 scoped_refptr<Extension> CreateExtensionWithID(const std::string& id); 31 // extensions side-by-side having distinct IDs.
32 scoped_refptr<Extension> CreateEmptyExtension(const std::string& id);
32 33
33 // Parses |json| allowing trailing commas and replacing single quotes with 34 // Parses |json| allowing trailing commas and replacing single quotes with
34 // double quotes for test readability. If the json fails to parse, calls gtest's 35 // double quotes for test readability. If the json fails to parse, calls gtest's
35 // ADD_FAILURE and returns an empty dictionary. 36 // ADD_FAILURE and returns an empty dictionary.
36 scoped_ptr<base::DictionaryValue> ParseJsonDictionaryWithSingleQuotes( 37 scoped_ptr<base::DictionaryValue> ParseJsonDictionaryWithSingleQuotes(
37 std::string json); 38 std::string json);
38 39
39 } // namespace test_util 40 } // namespace test_util
40 } // namespace extensions 41 } // namespace extensions
41 42
42 #endif // EXTENSIONS_COMMON_TEST_UTIL_H_ 43 #endif // EXTENSIONS_COMMON_TEST_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698