Compile chrome://settings, part 8: the final battle

chrome/browser/resources/options/manage_profile_overlay.js

Index: chrome/browser/resources/options/manage_profile_overlay.js
diff --git a/chrome/browser/resources/options/manage_profile_overlay.js b/chrome/browser/resources/options/manage_profile_overlay.js
index ad5e2030ba5d33a0e191fe309e6cc384d1c2594f..ab2d3cb6d62506270920575db733b683d1bf1061 100644
--- a/chrome/browser/resources/options/manage_profile_overlay.js
+++ b/chrome/browser/resources/options/manage_profile_overlay.js
@@ -418,7 +418,7 @@ cr.define('options', function() {
      * @private
      */
     onSigninError_: function() {
-      this.updateSignedInStatus_(this.signedInEmail_, true);
+      this.updateSignedInStatus(this.signedInEmail_, true);
     },
 
     /**
@@ -461,8 +461,15 @@ cr.define('options', function() {
         options.SupervisedUserListData.resetPromise();
     },
 
-    /** @private */
-    updateSignedInStatus_: assertNotReached,
+    /**
+     * Abstract method. Should be overriden in subclasses.
+     * @param {string} email
+     * @param {boolean} hasError
+     * @protected
+     */
+    updateSignedInStatus: function(email, hasError) {
+      assertNotReached();
+    },
 
     /**
      * Called when the user clicks "OK" or hits enter. Creates the profile
@@ -769,6 +776,15 @@ cr.define('options', function() {
     },
 
     /**
+     * @param {string} email
+     * @param {boolean} hasError

[Dan Beam, 2014/09/12 23:36:12]

^ remove

[Vitaly Pavlenko, 2014/09/13 00:02:37]

Done.

+     * @override
+     */
+    updateSignedInStatus: function(email, hasError) {
+      this.updateSignedInStatus_(email, hasError);

[Dan Beam, 2014/09/12 23:36:12]

uh, wat?

[Vitaly Pavlenko, 2014/09/13 00:02:36]

So, updateSignedInStatus is defined only in subclass, not in base class. Yet it
is called in base class:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

Yet it is exported to public API from subclass, so it should be defined as
private in subclass. But then if it's private subclass method, there's no other
chance for me to call it from base class methods other than create a method
wrapper with different visibility.

[Dan Beam, 2014/09/16 01:19:10]

why can't we just update cr.makePublic() to look for

  obj[name] || obj[name + '_']

and verify it's a function?  bad idea?

[Vitaly Pavlenko, 2014/09/16 03:36:55]

We could, but it will be used only in one place, here. We still need change this
JS file, so why not do all changes only here?

Moreover, it will make compiler pass doing more complex and magic things which
we gonna explain to people on final presentation. Do we want to?

With that in mind, make a decision, please.

+    },
+
+    /**
      * Updates the signed-in or not-signed-in UI when in create mode. Called by
      * the handler in response to the 'requestCreateProfileUpdate' message.
      * updateSupervisedUsersAllowed_ is expected to be called after this is, and