Compile chrome://settings, part 8: the final battle

ui/webui/resources/js/cr/ui/command.js

Index: ui/webui/resources/js/cr/ui/command.js
diff --git a/ui/webui/resources/js/cr/ui/command.js b/ui/webui/resources/js/cr/ui/command.js
index 302219cdf74ea181f6814a8e2e3f4ecf19282dca..494dc2eacda359611b99c9008a2ab6ffc6562147 100644
--- a/ui/webui/resources/js/cr/ui/command.js
+++ b/ui/webui/resources/js/cr/ui/command.js
@@ -241,7 +241,7 @@ cr.define('cr.ui', function() {
       var target = e.target;
 
       // Ignore focus on a menu button or command item
-      if (target.menu || target.command)
+      if ('menu' in target || 'command' in target)

[Dan Beam, 2014/09/12 23:36:12]

why? so they keys aren't changed during compilation?

[Vitaly Pavlenko, 2014/09/13 00:02:37]

.menu key is not defined on EventTarget, says the compiler. And these checks are
actually trying to understand the narrow type of e.target. Maybe replace is with
instanceof check?

[Dan Beam, 2014/09/16 01:19:10]

are you sure we need to bother with this at all?  I don't think focus bubbles so
this is probably dead code.

[Vitaly Pavlenko, 2014/09/16 03:36:55]

See my answer above.

[Dan Beam, 2014/09/19 01:05:55]

the problem with instanceof is that it doesn't work across frames.  that might
be OK, but checking for random properties isn't a great way in a compiled world.

[Vitaly Pavlenko, 2014/09/19 01:36:25]

So what do you think we should do with that?

[Dan Beam, 2014/09/23 02:19:53]

this is code is funky to start with.  i don't know how a command would get
focused (are these ever UI elements?).

as for menus: we can probably handle it in the capturing phase and either stop
the propagation or prevent the default (and ignore e.preventDefaulted == true).

+arv@: any thoughts?

         return;
 
       var commands = Array.prototype.slice.call(