Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change CreateChromeExtensionWebContentsObserver to DidInitialize Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc
diff --git a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc
index 177b9a78af6e901058898aff6b43b5ed281ef80c..eece99785c791955b933b7312dcf7653d5addd31 100644
--- a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc
+++ b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc
@@ -12,36 +12,35 @@
namespace extensions {
-ChromeExtensionOptionsGuestDelegate::ChromeExtensionOptionsGuestDelegate() {
+ChromeExtensionOptionsGuestDelegate::ChromeExtensionOptionsGuestDelegate(
+ ExtensionOptionsGuest* guest)
+ : ExtensionOptionsGuestDelegate(guest) {
}
ChromeExtensionOptionsGuestDelegate::~ChromeExtensionOptionsGuestDelegate() {
}
-void
-ChromeExtensionOptionsGuestDelegate::CreateChromeExtensionWebContentsObserver(
- content::WebContents* web_contents) {
+void ChromeExtensionOptionsGuestDelegate::DidInitialize() {
extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
- web_contents);
+ extension_options_guest()->web_contents());
}
bool ChromeExtensionOptionsGuestDelegate::HandleContextMenu(
- content::WebContents* web_contents,
const content::ContextMenuParams& params) {
- ContextMenuDelegate* menu_delegate =
- ContextMenuDelegate::FromWebContents(web_contents);
+ ContextMenuDelegate* menu_delegate = ContextMenuDelegate::FromWebContents(
+ extension_options_guest()->web_contents());
DCHECK(menu_delegate);
- scoped_ptr<RenderViewContextMenu> menu =
- menu_delegate->BuildMenu(web_contents, params);
+ scoped_ptr<RenderViewContextMenu> menu = menu_delegate->BuildMenu(
+ extension_options_guest()->web_contents(), params);
menu_delegate->ShowMenu(menu.Pass());
return true;
}
content::WebContents* ChromeExtensionOptionsGuestDelegate::OpenURLInNewTab(
- content::WebContents* embedder_web_contents,
const content::OpenURLParams& params) {
- Browser* browser = chrome::FindBrowserWithWebContents(embedder_web_contents);
+ Browser* browser = chrome::FindBrowserWithWebContents(
+ extension_options_guest()->embedder_web_contents());
return browser->OpenURL(params);
}

Powered by Google App Engine
This is Rietveld 408576698