Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 561053002: Remove tracing's nesting logic since noone is using it. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
tonyg, dtu, chrishenry, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove tracing's nesting logic since noone is using it. Cleanup tracing_backend_unittest BUG=400859 Committed: https://crrev.com/18cd46f23e277773ffa3b0ef2715d849999d76c7 Cr-Commit-Position: refs/heads/master@{#298310}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 5

Patch Set 3 : Remove current_category_filter tracking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -59 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 2 6 chunks +25 lines, -46 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 1 2 chunks +24 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
nednguyen
6 years, 3 months ago (2014-09-10 23:13:50 UTC) #2
tonyg
I don't know this part too well. Dave, would you mind taking a look please?
6 years, 3 months ago (2014-09-10 23:29:39 UTC) #5
nduca
lgtm on my part as long as dtu is happy
6 years, 3 months ago (2014-09-11 00:09:07 UTC) #6
nednguyen
6 years, 3 months ago (2014-09-11 22:32:17 UTC) #8
dtu
lol thanks guys, I'm also unfamiliar with this code https://chromiumcodereview.appspot.com/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right): https://chromiumcodereview.appspot.com/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py#newcode41 tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:41: ...
6 years, 3 months ago (2014-09-15 22:06:33 UTC) #9
nednguyen
https://chromiumcodereview.appspot.com/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right): https://chromiumcodereview.appspot.com/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py#newcode41 tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:41: if self.is_tracing_running: On 2014/09/15 22:06:33, dtu wrote: > Maybe ...
6 years, 3 months ago (2014-09-15 22:09:48 UTC) #10
chrishenry
https://codereview.chromium.org/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right): https://codereview.chromium.org/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py#newcode41 tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:41: if self.is_tracing_running: On 2014/09/15 22:09:47, nednguyen wrote: > On ...
6 years, 3 months ago (2014-09-23 17:49:27 UTC) #11
nednguyen
PTAL https://codereview.chromium.org/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right): https://codereview.chromium.org/561053002/diff/20001/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py#newcode41 tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:41: if self.is_tracing_running: On 2014/09/23 17:49:26, chrishenry wrote: > ...
6 years, 2 months ago (2014-10-03 17:13:48 UTC) #12
dtu
lgtm
6 years, 2 months ago (2014-10-06 23:18:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/561053002/40001
6 years, 2 months ago (2014-10-06 23:20:01 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 7b3d9e63d65f1626e604daf048252d269894da8c
6 years, 2 months ago (2014-10-07 00:04:17 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 00:04:54 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/18cd46f23e277773ffa3b0ef2715d849999d76c7
Cr-Commit-Position: refs/heads/master@{#298310}

Powered by Google App Engine
This is Rietveld 408576698