Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/resources/options/manage_profile_overlay.js

Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_3
Patch Set: manually handle exported methods declared in base class Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/manage_profile_overlay.js
diff --git a/chrome/browser/resources/options/manage_profile_overlay.js b/chrome/browser/resources/options/manage_profile_overlay.js
index 432629a2df0625a1f0261327963f34d5031d8e32..07459a5e0fd10a30571ae293b15ddbe8b23b8a39 100644
--- a/chrome/browser/resources/options/manage_profile_overlay.js
+++ b/chrome/browser/resources/options/manage_profile_overlay.js
@@ -593,7 +593,7 @@ cr.define('options', function() {
};
// Forward public APIs to private implementations.
- [
+ cr.makePublic(ManageProfileOverlay, [
'receiveDefaultProfileIconsAndNames',
'receiveNewProfileDefaults',
'receiveExistingProfileNames',
@@ -604,12 +604,7 @@ cr.define('options', function() {
'showDeleteDialog',
'showDisconnectManagedProfileDialog',
'showCreateDialog',
- ].forEach(function(name) {
- ManageProfileOverlay[name] = function() {
- var instance = ManageProfileOverlay.getInstance();
- return instance[name + '_'].apply(instance, arguments);
- };
- });
+ ]);
function CreateProfileOverlay() {
Page.call(this, 'createProfile',
@@ -849,7 +844,7 @@ cr.define('options', function() {
};
// Forward public APIs to private implementations.
- [
+ cr.makePublic(CreateProfileOverlay, [
'cancelCreateProfile',
'onError',
'onSuccess',
@@ -857,12 +852,7 @@ cr.define('options', function() {
'updateCreateInProgress',
'updateSignedInStatus',
'updateSupervisedUsersAllowed',
- ].forEach(function(name) {
- CreateProfileOverlay[name] = function() {
- var instance = CreateProfileOverlay.getInstance();
- return instance[name + '_'].apply(instance, arguments);
- };
- });
+ ]);
// Export
return {

Powered by Google App Engine
This is Rietveld 408576698