chrome/browser/resources/options/chromeos/keyboard_overlay.js - Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/keyboard_overlay.js

Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_3

Patch Set: manually handle exported methods declared in base class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/browser_options.js ('K') | « chrome/browser/resources/options/chromeos/change_picture_options.js ('k') | chrome/browser/resources/options/manage_profile_overlay.js » ('j') | third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/keyboard_overlay.js

diff --git a/chrome/browser/resources/options/chromeos/keyboard_overlay.js b/chrome/browser/resources/options/chromeos/keyboard_overlay.js

index 74680dbf7d6889452fc8a2e38c389276ad4f748b..5e6f2e01513e97533dae39188a50ac934e5ebf8d 100644

--- a/chrome/browser/resources/options/chromeos/keyboard_overlay.js

+++ b/chrome/browser/resources/options/chromeos/keyboard_overlay.js

@@ -161,15 +161,10 @@ cr.define('options', function() {

};

// Forward public APIs to private implementations.

- [

+ cr.makePublic(KeyboardOverlay, [

'showCapsLockOptions',

'showDiamondKeyOptions',

- ].forEach(function(name) {

- KeyboardOverlay[name] = function() {

- var instance = KeyboardOverlay.getInstance();

- return instance[name + '_'].apply(instance, arguments);

- };

- });

+ ]);

// Export

return {