Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Side by Side Diff: lib/web_ui.dart

Issue 55233009: Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/testing/render_test.dart ('k') | pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * This library exports all of the commonly used functions and types for 6 * This library exports all of the commonly used functions and types for
7 * building UI's. It is equivalent to the following imports: 7 * building UI's. It is equivalent to the following imports:
8 * 8 *
9 * import 'package:web_ui/observe.dart'; 9 * import 'package:web_ui/observe.dart';
10 * import 'package:web_ui/safe_html.dart'; 10 * import 'package:web_ui/safe_html.dart';
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 * Note that [root] will be a [ShadowRoot] if the browser supports Shadow DOM. 111 * Note that [root] will be a [ShadowRoot] if the browser supports Shadow DOM.
112 */ 112 */
113 void created() {} 113 void created() {}
114 114
115 /** Invoked when this component gets inserted in the DOM tree. */ 115 /** Invoked when this component gets inserted in the DOM tree. */
116 void inserted() {} 116 void inserted() {}
117 117
118 /** Invoked when this component is removed from the DOM tree. */ 118 /** Invoked when this component is removed from the DOM tree. */
119 void removed() {} 119 void removed() {}
120 120
121 // TODO(jmesserly): how do we implement this efficiently?
122 // See https://github.com/dart-lang/web-ui/issues/37
123 /** Invoked when any attribute of the component is modified. */
124 void attributeChanged(String name, String oldValue) {}
125
126
127 /** 121 /**
128 * **Note**: This is an implementation helper and should not need to be called 122 * **Note**: This is an implementation helper and should not need to be called
129 * from your code. 123 * from your code.
130 * 124 *
131 * If [ShadowRoot.supported] or [useShadowDom] is false, this distributes 125 * If [ShadowRoot.supported] or [useShadowDom] is false, this distributes
132 * children to the insertion points of the emulated ShadowRoot. 126 * children to the insertion points of the emulated ShadowRoot.
133 * This is an implementation helper and should not need to be called from your 127 * This is an implementation helper and should not need to be called from your
134 * code. 128 * code.
135 * 129 *
136 * This is an implementation of [composition][1] and [rendering][2] from the 130 * This is an implementation of [composition][1] and [rendering][2] from the
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 * traversal. 333 * traversal.
340 */ 334 */
341 bool useShadowDom = false; 335 bool useShadowDom = false;
342 336
343 bool get _realShadowRoot => useShadowDom && ShadowRoot.supported; 337 bool get _realShadowRoot => useShadowDom && ShadowRoot.supported;
344 338
345 /** 339 /**
346 * Set this to the [Element] to be used as the root for the Web UI app. 340 * Set this to the [Element] to be used as the root for the Web UI app.
347 */ 341 */
348 Element webUIRoot = document.body; 342 Element webUIRoot = document.body;
OLDNEW
« no previous file with comments | « lib/testing/render_test.dart ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698