Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: lib/web_ui.dart

Issue 55233009: Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/testing/render_test.dart ('k') | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/web_ui.dart
diff --git a/lib/web_ui.dart b/lib/web_ui.dart
index ab2bf6d696cc810d05fdec37c6ac55a88ae169d3..c79542d104970e17389c1d8503a326f35c937582 100644
--- a/lib/web_ui.dart
+++ b/lib/web_ui.dart
@@ -118,12 +118,6 @@ abstract class WebComponent extends CustomElement {
/** Invoked when this component is removed from the DOM tree. */
void removed() {}
- // TODO(jmesserly): how do we implement this efficiently?
- // See https://github.com/dart-lang/web-ui/issues/37
- /** Invoked when any attribute of the component is modified. */
- void attributeChanged(String name, String oldValue) {}
-
-
/**
* **Note**: This is an implementation helper and should not need to be called
* from your code.
« no previous file with comments | « lib/testing/render_test.dart ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698