Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: scripts/slave/recipe_modules/chromium/steps.py

Issue 550203002: Add mojo python bindings tests to the waterfalls. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Modified CL Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/steps.py
diff --git a/scripts/slave/recipe_modules/chromium/steps.py b/scripts/slave/recipe_modules/chromium/steps.py
index 9546ab4c9750b8a47b7c4346703177cc307b38c4..b65754ac8ede53a21d43a88f267818d594d43fb2 100644
--- a/scripts/slave/recipe_modules/chromium/steps.py
+++ b/scripts/slave/recipe_modules/chromium/steps.py
@@ -525,13 +525,35 @@ class MojoPythonTests(PythonBasedTest): # pylint: disable=W0232
**kwargs)
+class MojoPythonBindingsTests(PythonBasedTest): # pylint: disable=W0232
+ name = 'mojo_python_bindings_tests'
+
+ def run_step(self, api, suffix, cmd_args, **kwargs):
+ component = api.chromium.c.gyp_env.GYP_DEFINES.get('component', None)
+ # Python modules are not build for the component build.
+ if component == 'shared_library':
+ return None
+ args = cmd_args
+ args.extend(['--build-dir', api.chromium.c.build_dir])
+ return api.python(
+ self._step_name(suffix),
+ api.path['checkout'].join('mojo', 'tools',
+ 'run_mojo_python_bindings_tests.py'),
+ args,
+ **kwargs)
+
+ @staticmethod
+ def compile_targets(api):
+ return ['mojo_python', 'mojo_public_test_interfaces']
+
+
class PrintPreviewTests(PythonBasedTest): # pylint: disable=W032
name = 'print_preview_tests'
def run_step(self, api, suffix, cmd_args, **kwargs):
platform_arg = '.'.join(['browser_test',
api.platform.normalize_platform_name(api.platform.name)])
- args = list(cmd_args)
+ args = cmd_args
path = api.path['checkout'].join(
'webkit', 'tools', 'layout_tests', 'run_webkit_tests.py')
args.extend(['--platform', platform_arg])

Powered by Google App Engine
This is Rietveld 408576698