third_party/closure_compiler/checker.py - Issue 543863002: Typecheck chrome://bookmarks using Closure Compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/checker.py

Issue 543863002: Typecheck chrome://bookmarks using Closure Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/bookmark_manager/js/main.js ('k') | third_party/closure_compiler/externs/bookmark_manager_private.js » ('j') | third_party/closure_compiler/externs/bookmark_manager_private.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/checker.py

diff --git a/third_party/closure_compiler/checker.py b/third_party/closure_compiler/checker.py

index 5b215831883f220a85d65d7d1953246e56216c26..d06b3995e1a9047ff232425c78808ef17fb89dfa 100755

--- a/third_party/closure_compiler/checker.py

+++ b/third_party/closure_compiler/checker.py

@@ -60,6 +60,7 @@ class Checker(object):

current_dir = os.path.join(os.path.dirname(__file__))

self._compiler_jar = os.path.join(current_dir, "lib", "compiler.jar")

self._runner_jar = os.path.join(current_dir, "runner", "runner.jar")

+ self._chrome_extensions = os.path.join(current_dir, "chrome_extensions.js")

Dan Beam 2014/09/18 23:13:12 include when needed in gyp rather than always

Vitaly Pavlenko 2014/09/19 00:48:46 Done.

self._temp_files = []

self._verbose = verbose

@@ -170,6 +171,8 @@ class Checker(object):

depends = depends or []

externs = externs or []

+ externs = [self._chrome_extensions] + externs

Dan Beam 2014/09/18 23:13:12 externs += [self._chrome_extensions]

Vitaly Pavlenko 2014/09/19 00:48:46 Removed.

if not self._check_java_path():

return 1, ""