Typecheck chrome://bookmarks using Closure Compiler

third_party/closure_compiler/checker.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on a JavaScript file to check for errors."""
 
 import argparse
 import os
 import re
@@ skipping 42 matching lines @@
     "-client",
     "-XX:+TieredCompilation"
   ]
 
   _found_java = False
 
   def __init__(self, verbose=False):
     current_dir = os.path.join(os.path.dirname(__file__))
     self._compiler_jar = os.path.join(current_dir, "lib", "compiler.jar")
     self._runner_jar = os.path.join(current_dir, "runner", "runner.jar")
+    self._chrome_extensions = os.path.join(current_dir, "chrome_extensions.js")

[Dan Beam, 2014/09/18 23:13:12]

include when needed in gyp rather than always

[Vitaly Pavlenko, 2014/09/19 00:48:46]

Done.

     self._temp_files = []
     self._verbose = verbose
 
   def _clean_up(self):
     if not self._temp_files:
       return
 
     self._debug("Deleting temporary files: %s" % ", ".join(self._temp_files))
     for f in self._temp_files:
       os.remove(f)
@@ skipping 90 matching lines @@
             the page.
         externs: @extern files that inform the compiler about custom globals.
 
     Returns:
         (exitcode, output) The exit code of the Closure compiler (as a number)
             and its output (as a string).
     """
     depends = depends or []
     externs = externs or []
 
+    externs = [self._chrome_extensions] + externs

[Dan Beam, 2014/09/18 23:13:12]

externs += [self._chrome_extensions]

[Vitaly Pavlenko, 2014/09/19 00:48:46]

Removed.

+
     if not self._check_java_path():
       return 1, ""
 
     self._debug("FILE: %s" % source_file)
 
     if source_file.endswith("_externs.js"):
       self._debug("Skipping externs: %s" % source_file)
       return
 
     self._file_arg = source_file
@@ skipping 53 matching lines @@
     exit, _ = checker.check(source, depends=opts.depends, externs=opts.externs)
     if exit != 0:
       sys.exit(exit)
 
     if opts.out_file:
       out_dir = os.path.dirname(opts.out_file)
       if not os.path.exists(out_dir):
         os.makedirs(out_dir)
       # TODO(dbeam): write compiled file to |opts.out_file|.
       open(opts.out_file, "w").write("")