Move all typecasting code to individual screens.

Move all typecasting code to individual screens.
Re-introduce screen manager

BUG=231331
R=ygorshenin@chromium.org

Committed: https://crrev.com/c4bfe0a231bbba51cb573ddbe5d354efffd1d705
Cr-Commit-Position: refs/heads/master@{#293507}

[ygorshenin1, 2014-09-03 12:58:46]

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
(right):

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:19: //
static
Static methods definitions usually go after ctor and dtor.

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:21:
ScreenManager* manager) {
Please, add inclusion of chrome/browser/chromeos/login/screen_manager.h in all
files in the CL where ScreenManager is used.

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screen_manager.cc (right):

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_manager.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
s/(c) 2012/2014/

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_manager.cc:18: return iter->second.get();
nit: curly braces are usually not-needed around one-line branches.

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screen_manager.h (right):

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_manager.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
s/(c) 2012/2014/

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_manager.h:11: #include
"base/compiler_specific.h"
You don't need compiler_specific.h. Also you don't need hash_tables.h. Add
inclusion of "base/macros.h" for DISALLOW_COPY_AND_ASSIGN().

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/wizard_controller.h (right):

https://codereview.chromium.org/539483002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/wizard_controller.h:133: // ScreenManager
override.
s/override./implementation:/

[Denis Kuznetsov (DE-MUC), 2014-09-03 13:16:06]

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
(right):

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:19: //
static
On 2014/09/03 12:58:46, ygorshenin1 wrote:
> Static methods definitions usually go after ctor and dtor.

Acknowledged.

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:21:
ScreenManager* manager) {
On 2014/09/03 12:58:46, ygorshenin1 wrote:
> Please, add inclusion of chrome/browser/chromeos/login/screen_manager.h in all
> files in the CL where ScreenManager is used.

Done.

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/screen_manager.cc (right):

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screen_manager.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2014/09/03 12:58:46, ygorshenin1 wrote:
> s/(c) 2012/2014/

Acknowledged.

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/screen_manager.h (right):

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screen_manager.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2014/09/03 12:58:46, ygorshenin1 wrote:
> s/(c) 2012/2014/
> 

Acknowledged.

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screen_manager.h:11: #include
"base/compiler_specific.h"
On 2014/09/03 12:58:46, ygorshenin1 wrote:
> You don't need compiler_specific.h. Also you don't need hash_tables.h. Add
> inclusion of "base/macros.h" for DISALLOW_COPY_AND_ASSIGN().

Done.

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/wizard_controller.h (right):

https://chromiumcodereview.appspot.com/539483002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/wizard_controller.h:133: // ScreenManager
override.
On 2014/09/03 12:58:46, ygorshenin1 wrote:
> s/override./implementation:/

Done.

[ygorshenin1, 2014-09-03 13:30:22]

LGTM with nit.

https://chromiumcodereview.appspot.com/539483002/diff/20001/chrome/browser/ch...
File chrome/browser/chromeos/login/screens/user_image_screen.h (right):

https://chromiumcodereview.appspot.com/539483002/diff/20001/chrome/browser/ch...
chrome/browser/chromeos/login/screens/user_image_screen.h:11: #include
"chrome/browser/chromeos/login/screen_manager.h"
You dont' need inclusion of screen_manager.h here, as you already
forward-declared it. Move inclusion to the *.cc part.

[Denis Kuznetsov (DE-MUC), 2014-09-03 18:23:36]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-09-03 18:26:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/539483002/40001

[commit-bot: I haz the power, 2014-09-03 19:31:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 19:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:36:44]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Denis Kuznetsov (DE-MUC), 2014-09-04 09:46:09]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-09-04 09:47:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/539483002/40001

[commit-bot: I haz the power, 2014-09-04 12:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 12:41:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Denis Kuznetsov (DE-MUC), 2014-09-04 14:42:09]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-09-04 14:44:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/539483002/60001

[commit-bot: I haz the power, 2014-09-04 15:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 15:33:05]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[Denis Kuznetsov (DE-MUC), 2014-09-05 11:41:19]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-09-05 11:42:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/539483002/60001

[commit-bot: I haz the power, 2014-09-05 12:48:40]

Committed patchset #4 (id:60001) as 60fe0d04b30d0041d20ee91faff4f97de964b985

[commit-bot: I haz the power, 2014-09-10 03:39:05]

Patchset 4 (id:??) landed as
https://crrev.com/c4bfe0a231bbba51cb573ddbe5d354efffd1d705
Cr-Commit-Position: refs/heads/master@{#293507}