Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc

Issue 539483002: Move all typecasting code to individual screens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h" 9 #include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h"
10 #include "chrome/browser/chromeos/login/screens/mock_screen_observer.h" 10 #include "chrome/browser/chromeos/login/screens/mock_screen_observer.h"
(...skipping 19 matching lines...) Expand all
30 WizardController::kEnrollmentScreenName) {} 30 WizardController::kEnrollmentScreenName) {}
31 31
32 private: 32 private:
33 DISALLOW_COPY_AND_ASSIGN(EnrollmentScreenTest); 33 DISALLOW_COPY_AND_ASSIGN(EnrollmentScreenTest);
34 }; 34 };
35 35
36 IN_PROC_BROWSER_TEST_F(EnrollmentScreenTest, TestCancel) { 36 IN_PROC_BROWSER_TEST_F(EnrollmentScreenTest, TestCancel) {
37 ASSERT_TRUE(WizardController::default_controller() != NULL); 37 ASSERT_TRUE(WizardController::default_controller() != NULL);
38 38
39 EnrollmentScreen* enrollment_screen = 39 EnrollmentScreen* enrollment_screen =
40 WizardController::default_controller()->GetEnrollmentScreen(); 40 EnrollmentScreen::Get(WizardController::default_controller());
41 ASSERT_TRUE(enrollment_screen != NULL); 41 ASSERT_TRUE(enrollment_screen != NULL);
42 42
43 base::RunLoop run_loop; 43 base::RunLoop run_loop;
44 MockScreenObserver mock_screen_observer; 44 MockScreenObserver mock_screen_observer;
45 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ = 45 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ =
46 &mock_screen_observer; 46 &mock_screen_observer;
47 47
48 ASSERT_EQ(WizardController::default_controller()->current_screen(), 48 ASSERT_EQ(WizardController::default_controller()->current_screen(),
49 enrollment_screen); 49 enrollment_screen);
50 50
51 EXPECT_CALL(mock_screen_observer, 51 EXPECT_CALL(mock_screen_observer,
52 OnExit(ScreenObserver::ENTERPRISE_ENROLLMENT_COMPLETED)) 52 OnExit(ScreenObserver::ENTERPRISE_ENROLLMENT_COMPLETED))
53 .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit)); 53 .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
54 enrollment_screen->OnCancel(); 54 enrollment_screen->OnCancel();
55 content::RunThisRunLoop(&run_loop); 55 content::RunThisRunLoop(&run_loop);
56 Mock::VerifyAndClearExpectations(&mock_screen_observer); 56 Mock::VerifyAndClearExpectations(&mock_screen_observer);
57 57
58 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ = 58 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ =
59 WizardController::default_controller(); 59 WizardController::default_controller();
60 } 60 }
61 61
62 // Flaky test: crbug.com/394069 62 // Flaky test: crbug.com/394069
63 IN_PROC_BROWSER_TEST_F(EnrollmentScreenTest, DISABLED_TestSuccess) { 63 IN_PROC_BROWSER_TEST_F(EnrollmentScreenTest, DISABLED_TestSuccess) {
64 ASSERT_TRUE(WizardController::default_controller() != NULL); 64 ASSERT_TRUE(WizardController::default_controller() != NULL);
65 EXPECT_FALSE(StartupUtils::IsOobeCompleted()); 65 EXPECT_FALSE(StartupUtils::IsOobeCompleted());
66 66
67 EnrollmentScreen* enrollment_screen = 67 EnrollmentScreen* enrollment_screen =
68 WizardController::default_controller()->GetEnrollmentScreen(); 68 EnrollmentScreen::Get(WizardController::default_controller());
69 ASSERT_TRUE(enrollment_screen != NULL); 69 ASSERT_TRUE(enrollment_screen != NULL);
70 70
71 base::RunLoop run_loop; 71 base::RunLoop run_loop;
72 MockScreenObserver mock_screen_observer; 72 MockScreenObserver mock_screen_observer;
73 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ = 73 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ =
74 &mock_screen_observer; 74 &mock_screen_observer;
75 75
76 ASSERT_EQ(WizardController::default_controller()->current_screen(), 76 ASSERT_EQ(WizardController::default_controller()->current_screen(),
77 enrollment_screen); 77 enrollment_screen);
78 78
(...skipping 21 matching lines...) Expand all
100 test_data_dir.AppendASCII("kiosk_manifest.json")); 100 test_data_dir.AppendASCII("kiosk_manifest.json"));
101 } 101 }
102 102
103 DISALLOW_COPY_AND_ASSIGN(ProvisionedEnrollmentScreenTest); 103 DISALLOW_COPY_AND_ASSIGN(ProvisionedEnrollmentScreenTest);
104 }; 104 };
105 105
106 IN_PROC_BROWSER_TEST_F(ProvisionedEnrollmentScreenTest, TestBackButton) { 106 IN_PROC_BROWSER_TEST_F(ProvisionedEnrollmentScreenTest, TestBackButton) {
107 ASSERT_TRUE(WizardController::default_controller() != NULL); 107 ASSERT_TRUE(WizardController::default_controller() != NULL);
108 108
109 EnrollmentScreen* enrollment_screen = 109 EnrollmentScreen* enrollment_screen =
110 WizardController::default_controller()->GetEnrollmentScreen(); 110 EnrollmentScreen::Get(WizardController::default_controller());
111 ASSERT_TRUE(enrollment_screen != NULL); 111 ASSERT_TRUE(enrollment_screen != NULL);
112 112
113 base::RunLoop run_loop; 113 base::RunLoop run_loop;
114 MockScreenObserver mock_screen_observer; 114 MockScreenObserver mock_screen_observer;
115 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ = 115 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ =
116 &mock_screen_observer; 116 &mock_screen_observer;
117 117
118 ASSERT_EQ(WizardController::default_controller()->current_screen(), 118 ASSERT_EQ(WizardController::default_controller()->current_screen(),
119 enrollment_screen); 119 enrollment_screen);
120 120
121 EXPECT_CALL(mock_screen_observer, 121 EXPECT_CALL(mock_screen_observer,
122 OnExit(ScreenObserver::ENTERPRISE_ENROLLMENT_BACK)) 122 OnExit(ScreenObserver::ENTERPRISE_ENROLLMENT_BACK))
123 .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit)); 123 .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
124 enrollment_screen->OnCancel(); 124 enrollment_screen->OnCancel();
125 content::RunThisRunLoop(&run_loop); 125 content::RunThisRunLoop(&run_loop);
126 Mock::VerifyAndClearExpectations(&mock_screen_observer); 126 Mock::VerifyAndClearExpectations(&mock_screen_observer);
127 127
128 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ = 128 static_cast<WizardScreen*>(enrollment_screen)->screen_observer_ =
129 WizardController::default_controller(); 129 WizardController::default_controller();
130 } 130 }
131 131
132 } // namespace chromeos 132 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/enrollment/enrollment_screen.cc ('k') | chrome/browser/chromeos/login/screen_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698