Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 536473002: PlzNavigate: Initialize the renderer on commit (Closed)

Created:
6 years, 3 months ago by clamy
Modified:
6 years, 3 months ago
Reviewers:
carlosk, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Initialize the renderer on commit This CL makes sure that the renderer is initialized before being used to handle a navigation that has just committed. BUG=376082 Committed: https://crrev.com/2d298babb173025d622fd82da6486d0fa77154cb Cr-Commit-Position: refs/heads/master@{#293191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
clamy
@nasko: PTAL @carlosk: FYI I realized that I forgot to initialize the RenderViewHost after we ...
6 years, 3 months ago (2014-09-02 19:46:18 UTC) #2
nasko
LGTM
6 years, 3 months ago (2014-09-03 16:07:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/536473002/1
6 years, 3 months ago (2014-09-03 17:17:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-03 18:27:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/8394)
6 years, 3 months ago (2014-09-03 19:42:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/536473002/1
6 years, 3 months ago (2014-09-03 19:50:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as bf58d5e0f36ab33c7f0edb01930b113698de1df0
6 years, 3 months ago (2014-09-03 20:29:56 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:27:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d298babb173025d622fd82da6486d0fa77154cb
Cr-Commit-Position: refs/heads/master@{#293191}

Powered by Google App Engine
This is Rietveld 408576698