Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6427)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 536473002: PlzNavigate: Initialize the renderer on commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index acf5f139c4767ecea696694d8bceea8537a41bcd..21f1d2bfb6630ff0d72b198475db07c779d5720a 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -1758,8 +1758,10 @@ TEST_F(RenderFrameHostManagerTest,
render_manager->CommitNavigation(commit_info);
main_request = GetNavigationRequestForRenderFrameManager(render_manager);
- // The main RFH should not have been changed.
+ // The main RFH should not have been changed, and the renderer should have
+ // been initialized.
EXPECT_EQ(rfh, main_test_rfh());
+ EXPECT_TRUE(main_test_rfh()->render_view_host()->IsRenderViewLive());
}
// PlzNavigate: Test that a new RenderFrameHost is created when doing a cross
@@ -1791,6 +1793,7 @@ TEST_F(RenderFrameHostManagerTest,
render_manager->CommitNavigation(commit_info);
main_request = GetNavigationRequestForRenderFrameManager(render_manager);
EXPECT_NE(main_test_rfh(), rfh);
+ EXPECT_TRUE(main_test_rfh()->render_view_host()->IsRenderViewLive());
}
} // namespace content
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698