Make flakiness dashboard links to googlesource work post git migration.

Make flakiness dashboard links to googlesource work post git migration.

Change links to individual revisions to use crrev.com.

For revision ranges, create a local test-results url that queries
crrev.com for the git hashes and then hits googlesource directly.
This should eventually be part of crrev itself, but this is a
stopgap to get the flakiness dashboard working.

BUG=401856
Committed: https://chromium.googlesource.com/infra/infra/+/f66ad9172c691422a3d9159e9bffff6ea3c742d9

[ojan, 2014-08-25 01:55:07]

This patch depends on https://codereview.chromium.org/499103002.

[ojan, 2014-08-25 02:00:19]

I went ahead and pushed this out live already. No point in the dashboard being
broken while we review and land this. I'm not worried that there's any chance
this code could break something else in some lasting way.

[ghost stip (do not use), 2014-08-25 17:52:12]

we're looking into adding this directly to crrev, will update once I have an
idea on how that will work

[ojan, 2014-09-01 03:23:28]

How about we land this for now and we can delete the redirector.py stuff once
crrev supports this stuff directly?

[ojan, 2014-09-04 17:41:30]

ping. I'd like to push the flakiness dashboard today. I can push with this
locally, but it'd be nice to get tip of tree pushable.

[szager1, 2014-09-04 20:51:32]

lgtm with nit

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/m...
File appengine/test_results/main.py (right):

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/m...
appengine/test_results/main.py:43: webapp2.Route('/rev',
webapp2.RedirectHandler, defaults={
nit: Maybe '/revrange'?  Maybe '/rev' could redirect to the googlesource.com
page showing a single commit.

[ghost stip (do not use), 2014-09-04 22:53:25]

lgtm w/ comment

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
File appengine/test_results/handlers/redirector.py (right):

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
appengine/test_results/handlers/redirector.py:14: 
nit: 2 spaces

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
appengine/test_results/handlers/redirector.py:24: '/%s..%s?pretty=full' %
(start, end))
note: you may want pretty=fuller here, depending on if you want filenames or not

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
File appengine/test_results/main.py (right):

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
appengine/test_results/main.py:43: webapp2.Route('/rev',
webapp2.RedirectHandler, defaults={
On 2014/09/04 20:51:32, szager1 wrote:
> nit: Maybe '/revrange'?  Maybe '/rev' could redirect to the
http://googlesource.com
> page showing a single commit.

I agree with stefan here

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
File appengine/test_results/test/redirector_test.py (right):

https://chromiumcodereview.appspot.com/498083002/diff/40001/appengine/test_re...
appengine/test_results/test/redirector_test.py:34:
'aaaaaaa..bbbbbbb?pretty=full')
see other comment about pretty=fuller

[ojan, 2014-09-05 21:40:32]

The CQ bit was checked by ojan@chromium.org

[ojan, 2014-09-05 21:40:33]

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/h...
File appengine/test_results/handlers/redirector.py (right):

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/h...
appengine/test_results/handlers/redirector.py:14: 
On 2014/09/04 22:53:25, stip wrote:
> nit: 2 spaces

2 line breaks? If so, done. Why doesn't the linter enforce this?

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/h...
appengine/test_results/handlers/redirector.py:24: '/%s..%s?pretty=full' %
(start, end))
On 2014/09/04 22:53:25, stip wrote:
> note: you may want pretty=fuller here, depending on if you want filenames or
not

Done.

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/m...
File appengine/test_results/main.py (right):

https://codereview.chromium.org/498083002/diff/40001/appengine/test_results/m...
appengine/test_results/main.py:43: webapp2.Route('/rev',
webapp2.RedirectHandler, defaults={
On 2014/09/04 22:53:25, stip wrote:
> On 2014/09/04 20:51:32, szager1 wrote:
> > nit: Maybe '/revrange'?  Maybe '/rev' could redirect to the
> http://googlesource.com
> > page showing a single commit.
> 
> I agree with stefan here

I went verbose with revision_range

[commit-bot: I haz the power, 2014-09-05 21:40:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/498083002/60001

[commit-bot: I haz the power, 2014-09-05 21:44:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:44:14]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[ojan, 2014-09-05 21:50:18]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:51:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/498083002/80001

[commit-bot: I haz the power, 2014-09-05 21:52:48]

Committed patchset #5 (id:80001) as f66ad9172c691422a3d9159e9bffff6ea3c742d9