Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2931)

Unified Diff: appengine_apps/test_results/static-dashboards/ui.js

Issue 498083002: Make flakiness dashboard links to googlesource work post git migration. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@deployable
Patch Set: move test to the right location Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine_apps/test_results/static-dashboards/ui_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine_apps/test_results/static-dashboards/ui.js
diff --git a/appengine_apps/test_results/static-dashboards/ui.js b/appengine_apps/test_results/static-dashboards/ui.js
index 5a4c5b6e576459b10f2f672c7dae1c8ba53405a2..d06a757aaddc304318ce1749a231ef121d0195aa 100644
--- a/appengine_apps/test_results/static-dashboards/ui.js
+++ b/appengine_apps/test_results/static-dashboards/ui.js
@@ -175,8 +175,15 @@ ui.html._revisionLink = function(resultsKey, testResults, index)
var currentRevision = parseInt(testResults[resultsKey][index], 10);
var previousRevision = parseInt(testResults[resultsKey][index + 1], 10);
+ // TODO(ojan): chromium/src is the only repository supported by crrev.com.
+ // Once blink is supported, send all code down the isChrome codepath.
var isChrome = resultsKey == results.CHROME_REVISIONS;
- var singleUrl = 'http://src.chromium.org/viewvc/' + (isChrome ? 'chrome' : 'blink') + '?view=rev&revision=' + currentRevision;
+
+ var singleUrl;
+ if (isChrome)
+ singleUrl = 'https://crrev.com/' + currentRevision;
+ else
+ singleUrl = 'http://src.chromium.org/viewvc/blink?view=rev&revision=' + currentRevision;
if (currentRevision == previousRevision)
return 'At <a href="' + singleUrl + '">r' + currentRevision + '</a>';
@@ -184,9 +191,17 @@ ui.html._revisionLink = function(resultsKey, testResults, index)
if (currentRevision - previousRevision == 1)
return '<a href="' + singleUrl + '">r' + currentRevision + '</a>';
- var rangeUrl = 'http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog' +
- (isChrome ? '' : '_blink') + '.html?url=/trunk' + (isChrome ? '/src' : '') +
- '&range=' + (previousRevision + 1) + ':' + currentRevision + '&mode=html';
+ var rangeUrl;
+ if (isChrome) {
+ // Intentionally do not increment previous revision. This rev works the
+ // way gitiles does (exclude the start of the range) instead of the way
+ // the perf dashboard below does.
+ rangeUrl = '../../revision_range?start=' + previousRevision + '&end=' + currentRevision;
+ } else {
+ rangeUrl = 'http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk' +
+ '&range=' + (previousRevision + 1) + ':' + currentRevision + '&mode=html';
+ }
+
return '<a href="' + rangeUrl + '">r' + (previousRevision + 1) + ' to r' + currentRevision + '</a>';
}
« no previous file with comments | « no previous file | appengine_apps/test_results/static-dashboards/ui_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698