Dartium support for Uri.base (dart-side)

Dartium support for Uri.base (dart-side)

BUG=13581
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29479

[siva, 2013-10-28 18:44:51]

https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
File tools/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
tools/dom/src/native_DOMImplementation.dart:542: "is not supported in the
browser");
Shouldn't we have some kind of base for this too maybe based on the URI
specified in spawnUri ?

[vsm, 2013-10-29 14:10:53]

https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
File tools/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
tools/dom/src/native_DOMImplementation.dart:542: "is not supported in the
browser");
Any idea how I can get this base for a background isolate?  Who sets it?

On 2013/10/28 18:44:51, siva wrote:
> Shouldn't we have some kind of base for this too maybe based on the URI
> specified in spawnUri ?

[floitsch, 2013-10-29 18:05:20]

https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
File tools/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
tools/dom/src/native_DOMImplementation.dart:542: "is not supported in the
browser");
On 2013/10/29 14:10:53, vsm wrote:
> Any idea how I can get this base for a background isolate?  Who sets it?
> 
> On 2013/10/28 18:44:51, siva wrote:
> > Shouldn't we have some kind of base for this too maybe based on the URI
> > specified in spawnUri ?
> 

The spawnUri already comes with an initial message. We can easily extend it to
also receive a base-URI.
So, if you we agree on what should be there we can set it during the spawnUri
start-up.

[vsm, 2013-10-29 18:11:16]

On 2013/10/29 18:05:20, floitsch wrote:
>
https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
> File tools/dom/src/native_DOMImplementation.dart (right):
> 
>
https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
> tools/dom/src/native_DOMImplementation.dart:542: "is not supported in the
> browser");
> On 2013/10/29 14:10:53, vsm wrote:
> > Any idea how I can get this base for a background isolate?  Who sets it?
> > 
> > On 2013/10/28 18:44:51, siva wrote:
> > > Shouldn't we have some kind of base for this too maybe based on the URI
> > > specified in spawnUri ?
> > 
> 
> The spawnUri already comes with an initial message. We can easily extend it to
> also receive a base-URI.
> So, if you we agree on what should be there we can set it during the spawnUri
> start-up.

As Siva suggested, should it just be base on the argument to spawnUri?

Shall I modify this and the other CL to only overwrite dart:core's
_uriBaseClosure on the DOM-enabled isolate?  For a background isolate, can
spawnUri or spawnFunction set it up without a native hook in Dartium?

[vsm, 2013-10-29 18:23:37]

On 2013/10/29 18:11:16, vsm wrote:
> On 2013/10/29 18:05:20, floitsch wrote:
> >
>
https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
> > File tools/dom/src/native_DOMImplementation.dart (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/48733004/diff/1/tools/dom/src/native_D...
> > tools/dom/src/native_DOMImplementation.dart:542: "is not supported in the
> > browser");
> > On 2013/10/29 14:10:53, vsm wrote:
> > > Any idea how I can get this base for a background isolate?  Who sets it?
> > > 
> > > On 2013/10/28 18:44:51, siva wrote:
> > > > Shouldn't we have some kind of base for this too maybe based on the URI
> > > > specified in spawnUri ?
> > > 
> > 
> > The spawnUri already comes with an initial message. We can easily extend it
to
> > also receive a base-URI.
> > So, if you we agree on what should be there we can set it during the
spawnUri
> > start-up.
> 
> As Siva suggested, should it just be base on the argument to spawnUri?
> 
> Shall I modify this and the other CL to only overwrite dart:core's
> _uriBaseClosure on the DOM-enabled isolate?  For a background isolate, can
> spawnUri or spawnFunction set it up without a native hook in Dartium?

Sounds good.  Still waiting for an LGTM before landing.  :-)

[floitsch, 2013-10-29 18:28:42]

LGTM, assuming that the Dartium bindings (in a different code-base) set this
function.

[vsm, 2013-10-29 18:29:35]

On 2013/10/29 18:28:42, floitsch wrote:
> LGTM, assuming that the Dartium bindings (in a different code-base) set this
> function.

Yes, here's the other CL:

https://chromiumcodereview.appspot.com/48353003/

[vsm, 2013-10-29 19:06:30]

Committed patchset #1 manually as r29479 (presubmit successful).