content/browser/frame_host/navigation_controller_impl.h - Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Nasko's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl.h

diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h

index 82fac02487532cde807c85d0998f6f02246e29b4..c1b23ec06a3566c7d2322ddae3478b85419328ed 100644

--- a/content/browser/frame_host/navigation_controller_impl.h

+++ b/content/browser/frame_host/navigation_controller_impl.h

@@ -207,6 +207,14 @@ class CONTENT_EXPORT NavigationControllerImpl

// Discards only the pending entry.

void DiscardPendingEntry();

+ // Fills in the history parameters required by FrameMsg_Navigate and

+ // FrameMsg_CommitNavigation.

+ void FillHistoryParametersForNavigationEntry(

+ const NavigationEntryImpl& entry,

+ int* pending_history_list_offset,

+ int* current_history_list_offset,

+ int* current_history_list_length) const;

private:

friend class RestoreHelper;

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/browser/frame_host/navigator_impl.h » ('J')