PlzNavigate: implement CommitNavigation on the browser side

content/browser/frame_host/navigator_impl.h

Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index b461ae05cc6e2630c26f9e11cc7f51f854d2961a..e59a5d9cc81866ec13248c3ec70d7aaac6cd17cd 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -25,9 +25,15 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
   NavigatorImpl(NavigationControllerImpl* navigation_controller,
                 NavigatorDelegate* delegate);
 
+  // PlzNavigate: Returns a FramsMsg_Commit_Params filled in based on the
+  // contents of |entry|.
+  scoped_ptr<FrameMsg_CommitNavigation_Params>

[nasko, 2014/09/03 16:30:26]

Now that these are no longer static, they should move lower in the file. We tend
to have inherited methods first, then class specific methods later.

[clamy, 2014/09/03 22:23:44]

Done.

+      MakeCommitNavigationParams(
+          const NavigationEntryImpl& entry,
+          NavigationController::ReloadType reload_type);
+
   // Fills in |params| based on the content of |entry|.
-  static void MakeNavigateParams(const NavigationEntryImpl& entry,
-                                 const NavigationControllerImpl& controller,
+  void MakeNavigateParams(const NavigationEntryImpl& entry,
                                  NavigationController::ReloadType reload_type,
                                  base::TimeTicks navigation_start,
                                  FrameMsg_Navigate_Params* params);
@@ -77,7 +83,8 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
       bool user_gesture) OVERRIDE;
   virtual void CommitNavigation(
       RenderFrameHostImpl* render_frame_host,
-      const NavigationBeforeCommitInfo& info) OVERRIDE;
+      scoped_ptr<FrameMsg_CommitNavigation_Params> commit_navigation_params)
+      OVERRIDE;
 
  private:
   virtual ~NavigatorImpl() {}