Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a unit test for the reload case Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index b461ae05cc6e2630c26f9e11cc7f51f854d2961a..ffa18859d27b099802f09e2490d88d34d7c724e9 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -25,9 +25,17 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
NavigatorImpl(NavigationControllerImpl* navigation_controller,
NavigatorDelegate* delegate);
+ // PlzNavigate: Returns a FramsMsg_commit_Params filled in based on the
(Do not use) nasko 2014/08/28 16:39:08 nit: Uppercase _commit_.
clamy 2014/09/02 18:25:19 Done.
+ // contents of |entry|.
+ static scoped_ptr<FrameMsg_CommitNavigation_Params>
+ MakeCommitNavigationParams(
+ const NavigationEntryImpl& entry,
+ const NavigatorImpl* navigator,
+ NavigationController::ReloadType reload_type);
+
// Fills in |params| based on the content of |entry|.
static void MakeNavigateParams(const NavigationEntryImpl& entry,
- const NavigationControllerImpl& controller,
+ const NavigatorImpl* navigator,
NavigationController::ReloadType reload_type,
base::TimeTicks navigation_start,
FrameMsg_Navigate_Params* params);
@@ -77,7 +85,8 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
bool user_gesture) OVERRIDE;
virtual void CommitNavigation(
RenderFrameHostImpl* render_frame_host,
- const NavigationBeforeCommitInfo& info) OVERRIDE;
+ scoped_ptr<FrameMsg_CommitNavigation_Params> commit_navigation_params)
+ OVERRIDE;
private:
virtual ~NavigatorImpl() {}

Powered by Google App Engine
This is Rietveld 408576698