content/browser/frame_host/navigator.h - Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a unit test for the reload case Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | content/browser/frame_host/navigator_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator.h

diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h

index b47654839f0f9d70b0729f2c6284d931e1a4ed7b..b34e0c7205fb128237f75de97c45a9bd6d95aed9 100644

--- a/content/browser/frame_host/navigator.h

+++ b/content/browser/frame_host/navigator.h

@@ -12,6 +12,7 @@

class GURL;

struct FrameHostMsg_BeginNavigation_Params;

+struct FrameMsg_CommitNavigation_Params;

struct FrameHostMsg_DidCommitProvisionalLoad_Params;

struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;

@@ -123,8 +124,9 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {

// PlzNavigate

// Signal |render_frame_host| that a navigation is ready to commit (the

// response to the navigation request has been received).

- virtual void CommitNavigation(RenderFrameHostImpl* render_frame_host,

- const NavigationBeforeCommitInfo& info) {};

+ virtual void CommitNavigation(

+ RenderFrameHostImpl* render_frame_host,

+ scoped_ptr<FrameMsg_CommitNavigation_Params> commit_navigation_params) {}

protected:

friend class base::RefCounted<Navigator>;