Chromium Code Reviews Chromium Code Reviews
Issue
473853002:
Make it possible to test command buffer decoder functions with extension flags (Closed)
DescriptionMake it possible to test command buffer decoder functions with extension flags
Make it possible to test command buffer decoder functions even if they
have extension_flags specified in the function info.
Create new files for these autogenerated unit tests:
gles2_cmd_decoder_unittest_extensions{.cc,_autogen.h}.
Does not add any new unit tests, as the existing functions have manually
written tests that cover what current autogenerator can produce.
The idea is that for each new extension_flag function one would write a
new unit test class in gles2_cmd_decoder_unittest_extensions.cc. The
class initialize the decoder with the needed extensions, so that the
feature flag controlling the function would be enabled.
Changes the way the unit test class name is defined in
build_gles2_cmd_buffer.py. Now the class is parametrized by
the top-level function that writes out the service unit tests.
Thus it's not possible to use CWriter classes 'file number' property.
Instead, pass the name in the substitution dict. Define that the
methods generating service unittests accept varying number of
substitution dicts.
This is useful for supporting extensions such as upcoming
CHROMIUM_path_rendering, so that more of the decoder function unit tests
can be autogenerated.
BUG=344330
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290794
Patch Set 1 #Patch Set 2 : missing hunko #Patch Set 3 : fix one lint error #Patch Set 4 : add new decoder unittest file to gpu/BUILD.gn #Patch Set 5 : rebase #Patch Set 6 : add a hunk to avoid functions jumping between numbered unittests #
Total comments: 4
Patch Set 7 : address review comment #
Messages
Total messages: 24 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
